-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: move from poetry to hatch #1407
Conversation
Reviewer's Guide by SourceryThis pull request moves the build system from Poetry to Hatch. The changes primarily affect the Makefile, with updates to the pyproject.toml file (not shown in the diff). The PR also includes some minor updates to Python files for improved compatibility and code style. Architecture diagram for build system migration from Poetry to Hatchgraph TD;
A[Makefile] -->|Removed Poetry commands| B[Build System];
A -->|Updated Python versions| C[Python Environment];
B -->|New Build System| D[Hatch];
C -->|Supported Versions| E[3.10, 3.11, 3.12];
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @weibullguy - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please clarify how testing will be handled after removing the test-related targets from the Makefile? It's important to ensure that the project maintains its testing capabilities with the new build system.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To move the build system from Poetry to Hatch.
Describe how this was implemented.
Making necessary updates to pyproject.toml and Makefile.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
this PR. These problem areas have been decorated with an ISSUE: # comment.
Summary by Sourcery
Move the project's build system from Poetry to Hatch, updating configuration files and removing Poetry-specific commands from the Makefile. Enhance file operation functions by replacing shutil and dir_util with copyfile and copytree, and update Python version support in the Makefile.
Enhancements:
Build: