Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch build to rollup from bili #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

khamer
Copy link

@khamer khamer commented Oct 3, 2020

To address Issue #26. I tested using the esm, cjs, and iife (with vue from the cdn) using Parcel locally. Let me know if it needs any changes or you're seeing any issues and I'll get them fixed.

@Remeic
Copy link
Owner

Remeic commented Oct 4, 2020

Hi @khamer, thanks for this PR, can remove even "babel-preset-poi": "^10.0.2" and use @babel/preset-env
Please make attention to presets on babel config!

@Remeic Remeic added the hacktoberfest label for hacktoberfest event label Oct 4, 2020
@Remeic Remeic linked an issue Oct 4, 2020 that may be closed by this pull request
@khamer
Copy link
Author

khamer commented Oct 5, 2020

Hey @Remeic - I think I've made the changes you were looking for. It's now using @babel/preset-env and I did the recommended steps for libraries and used @babel/plugin-transform-runtime as well. npm test fails but it fails for me even without the PR too, so I'm not sure if that's being used.

@khamer
Copy link
Author

khamer commented Oct 25, 2020

Hey @Remeic - is there something else you're looking for here? Happy to make more changes.

@Remeic
Copy link
Owner

Remeic commented Oct 31, 2020

I wish add hacktoberfest accept label just in time, sorry for delay i have a lot of work to do in these days.
@khamer if in future you want to check the failing test you make me very happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest label for hacktoberfest event hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Rollup for building vue-highlighter
2 participants