Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoker remapping fails to consider target arguments #16

Open
Johni0702 opened this issue Jan 9, 2023 · 0 comments
Open

Invoker remapping fails to consider target arguments #16

Johni0702 opened this issue Jan 9, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Johni0702
Copy link
Member

Which will result in non-deterministic results if the source method has overloads, e.g. remapping from Fabric 1.19.3 to Forge:

import net.minecraft.sound.SoundEvent;
import net.minecraft.util.Identifier;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.gen.Invoker;

@Mixin(SoundEvent.class)
public interface SoundEventAccessor {

    @Invoker
    static SoundEvent invokeOf(Identifier identifier) {
        throw new AssertionError();
    }
}

may semi-randomly result in @Invoker("createFixedRangeEvent") instead of the expected @Invoker("createVariableRangeEvent").

@Johni0702 Johni0702 added the bug Something isn't working label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant