Version footer magic 🎩 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 8, 2018 13:59
env var that capistrano sets on deploy.
not reinventing the wheel :(
* sets height on footer to accomodate new version info
rococodogs
approved these changes
May 8, 2018
RudyOnRails
commented
Sep 13, 2018
| @@ -21,6 +21,7 @@ | |||
| append :linked_dirs, "db" | |||
| append :linked_dirs, "public/assets" | |||
| append :linked_files, "config/secrets.yml" | |||
| append :linked_files, ".env.production" | |||
There was a problem hiding this comment.
I am working on adding this my org's Sufia, and I can't remember what this line's purpose is. Anyone remember?
cc: @bess
There was a problem hiding this comment.
i think it was a deployment bugfix, rather than related to the git footer? short of the ENV['PROJECT_NAME'] being called in config/initializers/git_sha.rb, i can't find any instances of the ENV hash in this PR?
There was a problem hiding this comment.
Ahh, yes, that rings a bell! Thanks @malantonio, hope all's well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepoCamp/asc2018#16
Not the prettiest, but displays for now.