Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review RO-Crate 1.1-DRAFT new sections #97

Closed
9 of 10 tasks
stain opened this issue Sep 24, 2020 · 9 comments
Closed
9 of 10 tasks

Review RO-Crate 1.1-DRAFT new sections #97

stain opened this issue Sep 24, 2020 · 9 comments
Assignees
Labels
help wanted Extra attention is needed question Up for discussion
Milestone

Comments

@stain
Copy link
Contributor

stain commented Sep 24, 2020

Following discussion in call 2020-09-24 we will review RO-Crate 1.1-DRAFT until Thurs 2020-10-01, as we have added new sections that have not been proofread yet.

After review we aim to release 1.1 on Fri 2020-10-02.

From Changelog:

I merged #95 so you can navigate and edit the split files either from above or from https://www.researchobject.org/ro-crate/1.1-DRAFT/ - but note that "1.1-DRAFT" is missing from the left-hand menu before it is released. See Table of contents instead.

Volunteers per section:

Deadline: Thurs 2020-10-01

Either comment on this issue or make pull request/issue for changes.

@stain
Copy link
Contributor Author

stain commented Sep 24, 2020

@dgarijo or @ljgarcia, are either of you able to also check out HTTP server configuration? At least the English, I tested each of the configs.

@nsjuty I added Encoding file paths as well.

@ljgarcia I added Web-based Data Entities as it's also about URI/identifiers.

@stain stain added this to the RO-Crate 1.1 milestone Sep 24, 2020
@stain
Copy link
Contributor Author

stain commented Sep 28, 2020

Also TODO for myself (or a volunteer that knows make/pandoc):

  • @stain: Update Makefile to concatenate *.md in correct order
  • @stain: Ensure concatenated HTML has correct internal #internal links or do a clever sed
  • @stain: Make html/pdf for Zenodo (if above not possible, *zip of htmls)

@stain
Copy link
Contributor Author

stain commented Sep 28, 2020

For Friday:

@alaninmcr
Copy link
Contributor

To comply with the BioSchemas ComputationalWorkflow profile, the data entities MUST have the listed properties.

Better stated as: the data entities SHOULD comply with the BioSchemas ComputationalWorkflow profile. To comply with the profile, the data entities MUST ...

For FormalParameter, the data entities MUST describe the properties name, additionalType and encodingFormat.

@stain
Copy link
Contributor Author

stain commented Sep 29, 2020

@alaninmcr if we are listing the MUSTs from the BioSchemas profiles then presumably we should also list the SHOULDs?

See my attempt in #100 - I am not sure if this can get a bit big and scary and people might think "Oh I won't do workflows in RO-Crate then" - or do you think it's OK?

@stain
Copy link
Contributor Author

stain commented Sep 30, 2020

Thanks @nsjuty - merged #101 #102

@stain
Copy link
Contributor Author

stain commented Sep 30, 2020

The so-called "clever sed" (bfd9b2f) actually worked and I fixed Makefile to make the Zenodo PDF again.

Preview of concatenated PDF: https://www.dropbox.com/s/4mtrw4xj4mz9xav/ro-crate-1.1.0-RC1.pdf?dl=0

@ljgarcia
Copy link
Contributor

@dgarijo
Copy link
Contributor

dgarijo commented Sep 30, 2020

Summary of my changes:

@stain stain closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Up for discussion
Projects
None yet
Development

No branches or pull requests

5 participants