-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jekyll-rtd-theme and split 1.1-DRAFT into files per section #95
Conversation
To improve navigation I split out into multiple files with section numbering in TOC. For instance root data entity is a separate page. Some caveats with this theme:
I had to rearrange some of the section headings as before it was all under a massive Contextual entities. I tried to update all internal links that now go across pages now, but I may have got some wrong. Check if it makes sense. I only restructured the new In this style we could also move some of the frontpage homepage stuff to subpages, e.g. "Implementations" and "Community". I would also add "Specifications" to list the older versions there. Now we should not really merge this PR until we are agreed to release 1.1 as this would "promote" the "1.1-DRAFT" to the top-level menu. I would use that |
In #65 @ljgarcia suggested trying just-the-docs which looks really nice and modern in comparison: However I found this a bit cumbersome. I have to annotate Biggest drawback for me was that the internal section headings don't appear on the left and has to be added with a classical |
It looks nice, indeed an improvement. I tried the testing version provided by @stain and all links I tried worked for me. I like the previous and next buttons at the end of the page. What I am not so sure is the pencil icon on the top right. Do you want to encourage editions (via fork/PR) that directly? I do not expect much people will use this option, not sure if needed. There is also a sort of blink when navigating with the menu. When changing to another menu item, the page is re-loaded and I can see like a shadow of the logo. I guess it goes to the top of the menu but then immediately moves to where the menu was clicked. It is not a real issue so if it comes from the template I would leave it but maybe worth to have a quick look at it. I tried it out in Windows 10, Firefox and Chrome. |
Agree with @ljgarcia - looks good. IS there a way to get it as a single file without the navigation chopping it up into pages? Not sure if this is an issue? |
Discussed in call 2020-09-24 where it was agreed with @ptsefton @dgarijo @CaroleGoble @stain and the silent majority to change the theme. 1.1 is however in review for another week (see #97), so I'll merge this so reviewers can edit the splitted files; after setting the "exclude" flags so |
so that links also work on GitHub Pages
As suggested in #65 we need a better theme that shows the examples well/wide, and that has good navigation between sections.
This pull request changes the RO-Crate website to use the jekyll-rtd-theme by https://rundocs.io/
It has the same look-and-file as https://readthedocs.org/ with a table of content on the left - but working with Jekyll/Markdown instead of transitioning to Python/Sphinx/RST. It seems like quite an improvement for RO-Crate in terms of readability and navigation:
You can try it on https://stain.github.io/ro-crate/1.1-DRAFT/