Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split message cache #262

Open
vetss opened this issue Oct 31, 2017 · 1 comment
Open

Split message cache #262

vetss opened this issue Oct 31, 2017 · 1 comment
Assignees
Milestone

Comments

@vetss
Copy link
Contributor

vetss commented Oct 31, 2017

We need to add cache for incoming already splitted messages. This cache will contain correlation between a message segement reference_number + source_address + dest_address and a SMSC GW's messageId of a first found message segment.
This value will be then logged into a CDR.
This functionality demands extra processing and must be optional and turned off by default.

@vetss vetss self-assigned this Oct 31, 2017
@vetss vetss added this to the 7.4.0 milestone Oct 31, 2017
vetss added a commit to vetss/smscgateway that referenced this issue Oct 31, 2017
@vetss
Copy link
Contributor Author

vetss commented Oct 31, 2017

Hello @StanislawLeja

The initial fix was done by @StanislawLeja in the PR #251.

I have added the PR + my suggested fix into (and SMSSC GW latest code) https://github.com/vetss/smscgateway/commits/smsc_44_Split_message_cache

My comments for a previous solution:

  • checking of removeOldReferenceNumbers() at any segement may waste resources. I added some timer for periodically checking (check my fix)
  • your synch code at a new created object splitMessageData that means no synching between different concurrent invocations. I tried to refactor code (check my fix) to concantrate all updated in a single synchronised code segment
  • when stopping of SMSC GW we need to remove of MBean (check my fix)

What is till missed:

  1. I have not tested, we need to make this step at a live server
  2. the functionality must be optional and turned off by default, we need to add CLI / GUI for it
    We may use of CLI templeate for enabling (if no objections)
  • smsc set cdr_splitted_message_id true
  1. We need to update a manul for new CDR fields and a new CLI / GUI
  2. should we have CLI / GUI for RemoveOlderThanXSeconds . Should we add it ?
  3. I do not understand why we need SplitMessageCacheStruct class. If it is not needed, better to remove it.

@olenara olenara modified the milestones: 7.4.0, 7.5.0 Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants