Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Import button to Memory Viewer #1088

Merged
merged 1 commit into from
May 12, 2024

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented May 2, 2024

Allows importing search results exported from a previous search to be used as the initial state of a new search.

https://discord.com/channels/310192285306454017/310195377993416714/1199805920251744296

For example: If I had narrowed my search results down to four values:

$0056   67
$0058   01
$019F   00
$153A   00

I could export this, and then later import it again, which would initialize a new search containing those four addresses and their captured values. The first filter on "!=" would compare against the 67/01/00/00 values. Then future filters would proceed normally using the values captured from the previous filter.

Similar to loading states, the initial values come from the import (instead of before loading the state) and filters are applied based on the current state (after loading the state/after importing).

NOTE: does not work with ASCII, BitCount or 4-bit searches.

@Jamiras Jamiras added this to the 1.3.1 milestone May 2, 2024
@Jamiras Jamiras merged commit 067e8d3 into RetroAchievements:master May 12, 2024
6 checks passed
@Jamiras Jamiras deleted the feature/import_search branch May 12, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant