-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add endpoint for GetComments #2552
feat(api): Add endpoint for GetComments #2552
Conversation
I broke my tests before the last push. Fixing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint surfaces multiple security issues.
Comments for banned users are still returned even though they're invisible in the UI. Comments for users are still returned if they have their wall disabled.
I've converted this to a draft for now. After talking with Wes, there is a bigger effort going on to deprecate Permissions and start using Policies.
I will keep looking at this, but it's getting to a point that is out of my wheel house. I'd love for someone to work with me to make sure we get this done properly. |
Not entirely sure what I'm doing wrong:
|
…s not active. Prevent soft deleted comments from returning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking a lot better. I've spent some time trying to break things and I'm not able to. I have only one (minor) suggested refactor from this final review and then I think we'll be in good shape.
To address: #2081 (comment)