refactor: migrate settings page back-end code to controllers #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
commented
Aug 7, 2024
wescopeland
commented
Aug 8, 2024
database/migrations/2024_08_07_000000_update_emailconfirmations_table.php
Outdated
Show resolved
Hide resolved
wescopeland
commented
Aug 9, 2024
tests/Feature/Community/Controllers/UserSettingsControllerTest.php
Outdated
Show resolved
Hide resolved
Jamiras
reviewed
Aug 17, 2024
Jamiras
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the user settings page (controlpanel.php) back-end code to use Laravel controllers. As a result, almost all of the legacy public/request files used by the page have been deleted.
There should be almost no functional changes as part of this PR. This is a precursor to migrating the UI of the page to React.
Where feasible, code coverage has been added. Some methods are a bit difficult to test, such as those for resetting progress, as these still use legacy SQL queries.
Additionally, a migration is included for
EmailConfirmationsto add an incrementing primary key and auser_idcolumn.For controller tests, I deliberately kept these as separate test cases. In my opinion, the trade-off of longer test execution times for easier-to-maintain tests is worth it. I think our focus should be on speeding up test execution time.