Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Supported Game Files to React #2659

Merged

Conversation

wescopeland
Copy link
Member

I promise as more of these PRs come through they'll get smaller as the surface area of foundational work decreases 😓

This PR migrates the Supported Game Files page to React.js. There are a few changes to note:

  • The page now has a meta description which provides the number of hashes available for the game.
  • The copy in the embed under the page heading has been slimmed down to 3 short sentences. The first two sentences on the original page were mostly restating the same thing in different ways. I also swapped the order of the last two sentences, as we know now that people are likely to click on the 1st link they see - it would be reasonable that it's the game's forum topic.
  • The mobile UX has been greatly improved. Breadcrumbs have also been removed on mobile. There is quite a bit of UX research out there which suggests breadcrumbs can cause more harm than good on mobile, especially since mobile users can backswipe. Mobile users who land on the page sideways can still click the game avatar to land on the game page.
  • The page no longer requires authentication. See here.

Before
Screenshot 2024-08-30 at 9 10 49 PM

Screenshot 2024-08-30 at 9 11 02 PM

After
Screenshot 2024-08-30 at 9 10 26 PM

Screenshot 2024-08-30 at 9 10 36 PM

@wescopeland wescopeland requested a review from a team August 31, 2024 01:13
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the same console errors reported here: #2624 (comment), but otherwise seems functional.

@wescopeland wescopeland merged commit daa6893 into RetroAchievements:master Sep 3, 2024
5 checks passed
@wescopeland wescopeland deleted the supported-game-files-react branch September 3, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants