Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up Laravel Pulse #2661

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

wescopeland
Copy link
Member

Adds Laravel Pulse observability to the server.

After running the auto-generated migration, Pulse is accessible via the /pulse route. It looks something like this:

Screenshot 2024-08-31 at 2 28 35 PM

Some other notes:

  • Accessible only to users with the admin or root role.
  • In config/pulse.php, I've set up modest sampling rates so we're not writing an excessive amount of data to the DB.

@wescopeland wescopeland requested a review from a team August 31, 2024 18:29
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what to test here, but it loads up, and doesn't seem to affect anything else noticeably - although I'm hardly putting any load on the system.

@wescopeland
Copy link
Member Author

Yea, probably not much to test here other than it loads up fine. If we do find that it puts noticeable load on the system, we can aggressively scale back the sampling rate.

We'll need to remember to update the settings JSON file in app storage on deploy so the new menu option will appear.

@wescopeland wescopeland merged commit 24ccfab into RetroAchievements:master Sep 7, 2024
5 checks passed
@wescopeland wescopeland deleted the setup-pulse branch September 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants