feat: migrate User Recent Posts to React.js #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
commented
Sep 1, 2024
| @@ -322,7 +323,7 @@ private function buildRankMetadata( | |||
| private function buildSocialStats(User $user): array | |||
| { | |||
| $userSetRequestInformation = getUserRequestsInformation($user); | |||
| $numForumPosts = $user->forumPosts()->count(); | |||
| $numForumPosts = $user->forumPosts()->authorized()->viewable(Auth::user())->count(); | |||
There was a problem hiding this comment.
This change fixes a bug on the user profile. The current count of forum posts represents all posts made by the user, including the ones that can't be seen due to being unauthorized or locked behind a permissions gate.
The count now reflects the posts that are visible on the /user/[user]/posts page.
Jamiras
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on #2663.
This PR migrates the
/user/[user]/postsroute to React.js. This is achieved by largely reusing components from the/forums/recent-postspage.There should only be one functional change on the page - it has been renamed from "Recent Posts" to "Forum Posts".