refactor: migrate the Random Set route to a controller method #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamiras
approved these changes
Sep 2, 2024
| @@ -121,7 +121,7 @@ | |||
| <x-dropdown-item :href="url('setRequestList.php')">Most Requested</x-dropdown-item> | |||
| <x-dropdown-item :href="route('claims.completed')">New Sets & Revisions</x-dropdown-item> | |||
| <x-dropdown-item :href="route('claims.active')">Sets in Progress</x-dropdown-item> | |||
| <x-dropdown-item :href="route('game.random')">Random Set</x-dropdown-item> | |||
| <x-dropdown-item :href="route('game.random')">Random Game</x-dropdown-item> | |||
There was a problem hiding this comment.
There is one functional change. The "Random Set" label has been changed to "Random Game". IMO, this better describes what the logic is actually doing - redirecting the user to a game page.
The idea behind using "Random Set" is that it only returns games with achievements.
There was a problem hiding this comment.
That makes sense. A fear I have is what this might mean if/when we're at a point that we're rendering multiple sets on the same game page. Let's cross that bridge when we get to it.
For now, I've reverted this label back to "Random Set".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This route doesn't fit well into React. This PR drops the Blade template and moves the logic directly into a controller.
There is one functional change. The "Random Set" label has been changed to "Random Game". IMO, this better describes what the logic is actually doing - redirecting the user to a game page. "Set" may also not be a well understood term outside of power users and developers.