fix(deps): bump filament to latest to fix some Laravel 11 compatibility issues #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wescopeland
commented
Sep 2, 2024
There was a problem hiding this comment.
These are all linting changes. Bumping Filament must have also bumped phpstan or something phpstan depends on. New errors started being thrown in this file from $matches[1] and $matches[2] always being truthy (the isset() and conditional are redundant).
Jamiras
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filament on stage is exhibiting some strange behavior stemming from vendor code.
For example, if you navigate to https://stage.retroachievements.org/manage/games/1, then scroll down and click the Leaderboards tab, then try to do a row action, nothing will happen and you'll get a bunch of console errors:
This was resolved in a Filament release a few months ago (filamentphp/filament#13178). Bumping to latest seems to fix the issue.