Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manage): improve management of invisible leaderboards #2688

Merged
merged 4 commits into from
Sep 14, 2024
Merged

fix(manage): improve management of invisible leaderboards #2688

merged 4 commits into from
Sep 14, 2024

Conversation

wescopeland
Copy link
Member

Makes two changes to leaderboard management:

  1. Display orders can now be manually entered to allow setting a leaderboard to be invisible (this can't be done from manual reordering).

Screenshot 2024-09-12 at 9 02 08 AM

  1. When using drag+drop to reorder leaderboards, rows with a < 0 DisplayOrder will not automatically be adjusted on each drop action (so they stay invisible).

Screenshot 2024-09-12 at 9 02 45 AM

@wescopeland wescopeland requested a review from a team September 12, 2024 13:03
Jamiras
Jamiras approved these changes Sep 12, 2024
View reviewed changes
app/Filament/Resources/LeaderboardResource.php Outdated Show resolved Hide resolved
@wescopeland wescopeland merged commit 0b204f4 into RetroAchievements:master Sep 14, 2024
6 checks passed
@wescopeland wescopeland deleted the manage-invisible-leaderboards branch September 14, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamiras Jamiras Jamiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wescopeland @Jamiras