feat(game): add sort_title field and backfill command
#2690
Conversation
wescopeland
added
the
deployment/command
| $action = new WriteGameSortTitleFromGameTitleAction(); | ||
| Game::query()->chunk(100, function ($games) use ($progressBar, $action) { | ||
| foreach ($games as $game) { | ||
| $action->execute($game, $game->title, shouldRespectCustomSortTitle: false); |
There was a problem hiding this comment.
Would it be overly ambitious to re-normalize articles?
Legend of Zelda, The: A Link to the Past => The Legend of Zelda: A Link to the Past with a sort title of just legend of zelda: a link to the past
Bug's Life, A => A Bug's Life with a sort title of bug's life
There was a problem hiding this comment.
Tricky, but I think I got it in latest. Added a few tests which seem to verify the new behavior is okay.
There was a problem hiding this comment.
Just to clarify, would you like to also see the game titles themselves readjust the placement of the articles?
There was a problem hiding this comment.
That's the goal state. Per #1062:
Ignore definite and indefinite articles at the start of titles so we don't have to rename them to force the correct sorting order.
Doing so now would break the sort order until the queries were updated to use the new sort column.
database/migrations/platform/2024_09_12_000000_update_gamedata_table.php
Outdated
Show resolved
Hide resolved
tests/Feature/Platform/Action/WriteGameSortTitleFromGameTitleActionTest.php
Show resolved
Hide resolved
| $action = new WriteGameSortTitleFromGameTitleAction(); | ||
| Game::query()->chunk(100, function ($games) use ($progressBar, $action) { | ||
| foreach ($games as $game) { | ||
| $action->execute($game, $game->title, shouldRespectCustomSortTitle: false); |
There was a problem hiding this comment.
That's the goal state. Per #1062:
Ignore definite and indefinite articles at the start of titles so we don't have to rename them to force the correct sorting order.
Doing so now would break the sort order until the queries were updated to use the new sort column.
tests/Feature/Platform/Action/WriteGameSortTitleFromGameTitleActionTest.php
Outdated
Show resolved
Hide resolved
tests/Feature/Platform/Action/WriteGameSortTitleFromGameTitleActionTest.php
Outdated
Show resolved
Hide resolved
tests/Feature/Platform/Action/ComputeGameSortTitleActionTest.php
Outdated
Show resolved
Hide resolved
Implements #1062.
Developed to resolve the performance issue mentioned in #2686 (comment).
sail artisan ra:platform:write-game-sort-titles 1 # write by IDsail artisan ra:platform:write-game-sort-titles # write them allThis PR adds a
sort_titlefield to theGameDatatable.We are actually already using this field on most game lists. However, it is computed on the fly in memory by PHP.
This PR's changeset simply moves that logic to a database column, ensures it's written to when the game title changes, and allows moderators/admins to override the field in the management app.
If a custom
sort_titleis provided, the new action is smart enough to detect this and not override it.