Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make some minor datatable ux improvements #2734

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

wescopeland
Copy link
Member

Stacked on #2727. This PR's actual diff is around +140 insertions.


This PR makes a few minor UX improvements to the React datatable:

  1. Light mode accessibility has been improved:
    Before
    Screenshot 2024-10-01 at 5 52 26 PM

After
Screenshot 2024-10-01 at 5 52 31 PM

  1. Hovering over the "Reset" button now initiates a prefetch if the destination data is not already cached (ie: a fresh page load with filters applied):
Area.mp4
  1. Filter checkboxes now have similar styles to checkboxes on the settings page (<BaseCheckbox />):
    Before
    Screenshot 2024-10-01 at 6 03 34 PM

After
Screenshot 2024-10-01 at 6 03 21 PM

  1. Fixed a console error that would sometimes be thrown when looking at the RetroPoints tooltip.

  2. On the "Has achievements" filter, changed the "Either" label to "Both".

  3. Added a minimum width to the title column.

@wescopeland wescopeland requested a review from a team October 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant