split RC_CONSOLE_FAMICOM_DISK_SYSTEM from RC_CONSOLE_NINTENDO #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new enum and alternate memory map and labels for the Famicom Disk System.
https://discord.com/channels/310192285306454017/1124566547797655692/1310992211730763888
https://discord.com/channels/310192285306454017/1124566547797655692/1311347053934149732
FDS games will continue to return
RC_CONSOLE_NINTENDOfrom the server at least until an updated DLL and RAlibretro are released as the DLL will complain if the console_id returned from the server doesn't match the console_id it was initialized with.RetroArch doesn't really initialize itself with a console, so it should still work with old clients and the new console_id.