Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MetaData.cpp #679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MetaData.cpp #679

wants to merge 1 commit into from

Conversation

JoseFC3000
Copy link

I think is better don't to shot 'unknow' when no info in those fields. This is anoying especially when you are in Favorites and no games in in the list and you see 'Unknown' in the fields

{"developer", MD_STRING, "unknown", false, "developer", "enter game developer"},
{"publisher", MD_STRING, "unknown", false, "publisher", "enter game publisher"},
{"genre", MD_STRING, "unknown", false, "genre", "enter game genre"},
{"releasedate", MD_DATE, "", false, "release date", "enter release date"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimeUtil.cpp compares with "not-a-date-time" string value - unsure if there are other scenarios where this type of change may break other things. Please assess or at least address this impact if possible.

@pjft
Copy link
Collaborator

pjft commented Mar 2, 2021

Thanks @JoseFC3000 for sending this over, and thank you for putting in the time and effort of making this recommendation.

I added some comments about the impact of this change that would need to be addressed, but more than that, I want to share some context on where I'm at with this proposal. I agree that this is very much a personal preference topic, and precisely because of that I am not confident that this change should be incorporated without further thought or validation. The fact is that this has been around in ES for ages, and no complaints have ever emerged about it.

I personally don't feel strongly one way or another (maybe other project members will), but the fact that this has long been accepted as the expected behavior may end up making a lot of users voice their preferences the other way around, turning this to a context of "who speaks the loudest".

May I ask if you have run this proposal by the forums, specifically in the "Ideas and Development" section, and see if you get some critical mass of people commenting about whether they agree with you that this would be indeed a clear improvement, and whether there'd be any existing theme where such a change would break the expected look and feel, for instance?

Getting some data here could help facilitate a decision on this but, unless someone else from the project has a strong preference one way or the other, my preference will be to hold out on this until we find that this is something that should indeed become the new default. If you already have such feedback, then please share it - thanks!

Hope this clarifies the lack of movement on this PR, and as I was reviewing some these past few days I thought it'd be fair to at least share a possible way forward.

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants