runcommand: add more parameters for RetroArch #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joolswills
reviewed
Jun 14, 2022
Added 2 new parameters for the runtime-generated `retroarch.cfg`: * `libretro_log_level` will add more debug messages from the libretro core, in addition to the frontend debugging messages. Cand be useful to diagnose core issues, since `--verbose` activates just the frontend logging. * `libretro_directory` is set to the core file folder (i.e. `/opt/retropie/libretrocores/lr-<core>`). It is used by during netplay, as a client, when RetroArch attempts to re-load the core used during netplay. Basically, when connecting to a remote netplay host, RetroArch will try to locate a `core.info` file and then try to re-load the core file. If any of them is missing, the connection fails with "Couldn't find a suitable core or content file". The netplay issue was reported and diagnosed in RetroPie#3161. Rather than symlink each installed libretro core to `$HOME/.config/retroarch/cores` (the default value for `libretro_directory`), we'll just set it at runtime with the above parameter. We still need to add the `.info` files for the installed cores, but that's a separate patch.
cmitu
force-pushed
the
runcommand-libretro-updates
branch
from
fd9084d
to
553c4fe
Compare
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 new parameters for the runtime-generated
retroarch.cfg:libretro_log_levelwill add more debug messages from the libretro core, in addition to the frontend debugging messages.Cand be useful to diagnose core issues, since
--verboseactivates just the frontend logging.libretro_directoryis set to the core file folder (i.e./opt/retropie/libretrocores/lr-<core>).It is used by during netplay, as a client, when RetroArch attempts to re-load the core used during netplay.
Basically, when connecting to a remote netplay host, RetroArch will try to locate a
core.infofile and then try to re-load the core file. If any of them is missing, the connection fails with "Couldn't find a suitable core or content file".The netplay issue was reported and diagnosed in Problems with netplay guest #3161. Rather than symlink each installed libretro core to
$HOME/.config/retroarch/cores(the default value forlibretro_directory), we'll just set it at runtime with the above parameter. We still need to add the.infofiles for the installed cores, but that's a separate patch.