Merge pull request #1619 from RexOps/fail_tests_on_warnings

Fix test suite warnings
RexOps · Aug 23, 2024 · 5552341 · 5552341
2 parents c5325d5 + f3a91ff
commit 5552341
Show file tree

Hide file tree

Showing 82 changed files with 179 additions and 83 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -4,6 +4,7 @@ Revision history for Rex
  [API CHANGES]
 
  [BUG FIXES]
+ - Return only the first found command
 
  [DOCUMENTATION]
 

diff --git a/lib/Rex/Interface/Exec/Base.pm b/lib/Rex/Interface/Exec/Base.pm
@@ -65,16 +65,16 @@ sub can_run {
       return $cache->get($cache_key_name);
     }
 
-    my $output = Rex::Helper::Run::i_run "$check_with_command $command",
+    my @output = Rex::Helper::Run::i_run "$check_with_command $command",
       fail_ok => 1;
 
     next if ( $? != 0 );
 
-    next if ( !is_file($output) );
+    next if ( !is_file( $output[0] ) );
 
-    $cache->set( $cache_key_name, $output );
+    $cache->set( $cache_key_name, $output[0] );
 
-    return $output;
+    return $output[0];
   }
 
   return undef;

diff --git a/t/0.31.t b/t/0.31.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 139;
+use Test::More tests => 140;
+use Test::Warnings;
 
 use Rex -feature => '0.31';
 

diff --git a/t/0.54.t b/t/0.54.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 13;
+use Test::More tests => 14;
+use Test::Warnings;
 
 use Rex -feature => '0.54';
 

diff --git a/t/01.t b/t/01.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 3;
+use Test::More tests => 4;
+use Test::Warnings;
 
 use Rex::Commands;
 

diff --git a/t/args.t b/t/args.t
@@ -6,6 +6,7 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 use Test::More;
+use Test::Warnings;
 
 use Rex::Args;
 

diff --git a/t/auth.t b/t/auth.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 48;
+use Test::More tests => 49;
+use Test::Warnings;
 
 use Rex::Commands;
 use Rex::Group;

diff --git a/t/base_virt.t b/t/base_virt.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::Warnings;
 
 use Rex::Virtualization;
 

diff --git a/t/batch.t b/t/batch.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::Warnings;
 use Rex::Commands;
 use Rex::Batch;
 

diff --git a/t/before_all_tasks.t b/t/before_all_tasks.t
@@ -7,6 +7,7 @@ use lib 't/lib';
 our $VERSION = '9999.99.99_99'; # VERSION
 
 use Test::More;
+use Test::Warnings;
 use Test::Deep;
 
 use Rex::Commands;

diff --git a/t/can_run.t b/t/can_run.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 4;
+use Test::More tests => 5;
+use Test::Warnings;
 
 use Rex::Commands::Run;
 

diff --git a/t/case.t b/t/case.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 7;
+use Test::More tests => 8;
+use Test::Warnings;
 use Rex::Commands;
 
 my $test = "Debian";

diff --git a/t/cmdb.t b/t/cmdb.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 2;
+use Test::More tests => 3;
+use Test::Warnings;
 
 use Cwd qw(realpath);
 use File::Spec;

diff --git a/t/cmdb_path.t b/t/cmdb_path.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 3;
+use Test::More tests => 4;
+use Test::Warnings;
 
 use Cwd qw(realpath);
 use File::Spec;

diff --git a/t/commands.t b/t/commands.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 18;
+use Test::More tests => 19;
+use Test::Warnings;
 
 use Rex::Commands;
 

diff --git a/t/commands/evaluate_hostnames.t b/t/commands/evaluate_hostnames.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 9;
+use Test::More tests => 10;
+use Test::Warnings;
 use Rex::Commands;
 
 my %tests = (

diff --git a/t/commands/iptables.t b/t/commands/iptables.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 32;
+use Test::More tests => 33;
+use Test::Warnings;
 
 use Rex::Commands::Iptables;
 

diff --git a/t/commands_file_template.t b/t/commands_file_template.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 4;
+use Test::More tests => 5;
+use Test::Warnings;
 
 use File::Basename;
 

diff --git a/t/config-ssh.t b/t/config-ssh.t
@@ -6,7 +6,8 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 use File::Temp;
-use Test::More tests => 21;
+use Test::More tests => 22;
+use Test::Warnings;
 
 use Rex::Config;
 

diff --git a/t/config.t b/t/config.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 10;
+use Test::More tests => 11;
+use Test::Warnings;
 
 use Cwd qw(realpath);
 use Rex::Config;

diff --git a/t/cron.t b/t/cron.t
@@ -6,8 +6,9 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 use Test::More;
+use Test::Warnings;
 
-$^O =~ m/^MSWin/ ? plan tests => 83 : plan tests => 286;
+$^O =~ m/^MSWin/ ? plan tests => 84 : plan tests => 287;
 
 use Rex::Cron::Base;
 

diff --git a/t/db.t b/t/db.t
@@ -7,6 +7,7 @@ our $VERSION = '9999.99.99_99'; # VERSION
 
 BEGIN {
   use Test::More;
+  use Test::Warnings;
   use Data::Dumper;
 
   eval "use DBI; 1" or plan skip_all => "Could not load DBI module";
@@ -29,7 +30,7 @@ my $mysqld = Test::mysqld->new(
   plan skip_all => $Test::mysqld::errstr;
   };
 
-plan tests => 38;
+plan tests => 39;
 
 $dbh = DBI->connect( $mysqld->dsn( dbname => 'test' ), );
 Rex::Commands::DB->import( { dsn => $mysqld->dsn( dbname => 'test' ) } );

diff --git a/t/df.t b/t/df.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 36;
+use Test::More tests => 37;
+use Test::Warnings;
 
 use Rex::Commands::Fs;
 

diff --git a/t/dmi.t b/t/dmi.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 31;
+use Test::More tests => 32;
+use Test::Warnings;
 
 use Rex::Inventory::DMIDecode;
 

diff --git a/t/do_task.t b/t/do_task.t
@@ -6,7 +6,8 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 use Rex::Commands;
-use Test::More tests => 4;
+use Test::More tests => 5;
+use Test::Warnings;
 
 eval { Rex::Commands::do_task("non_existing_task"); };
 my $result = $@;

diff --git a/t/env.t b/t/env.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 1;
+use Test::More tests => 2;
+use Test::Warnings;
 
 use Rex::Commands::Run;
 

diff --git a/t/file.t b/t/file.t
@@ -10,7 +10,8 @@ my $cwd = getcwd;
 use File::Spec;
 use File::Temp;
 
-use Test::More tests => 61;
+use Test::More tests => 62;
+use Test::Warnings;
 
 use Rex::Commands::File;
 use Rex::Commands::Fs;

diff --git a/t/file_hooks.t b/t/file_hooks.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 3;
+use Test::More tests => 4;
+use Test::Warnings;
 use Test::Deep;
 use Test::Output;
 

diff --git a/t/fs_files.t b/t/fs_files.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 13;
+use Test::More tests => 14;
+use Test::Warnings;
 
 use Rex::Helper::Path;
 use Rex::Commands::File;

diff --git a/t/group.t b/t/group.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 98;
+use Test::More tests => 99;
+use Test::Warnings;
 use Test::Exception;
 
 use Rex -feature => '0.31';

diff --git a/t/helper_hash.t b/t/helper_hash.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 6;
+use Test::More tests => 7;
+use Test::Warnings;
 
 use Rex::Helper::Hash;
 

diff --git a/t/helper_path.t b/t/helper_path.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 8;
+use Test::More tests => 9;
+use Test::Warnings;
 
 use File::Basename;
 use Cwd 'getcwd';

diff --git a/t/hooks.t b/t/hooks.t
@@ -6,7 +6,8 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 BEGIN {
-  use Test::More tests => 8;
+  use Test::More tests => 9;
+  use Test::Warnings qw(:no_end_test had_no_warnings);
   use File::Temp;
   use Rex::Commands;
   use Rex::RunList;
@@ -49,3 +50,5 @@ is $after,                   1, 'after hook';
 is $after_all,               1, 'after ALL hook';
 is $after_task_finished,     1, 'after_task_finished hook';
 is $after_task_finished_all, 1, 'after_task_finished ALL hook';
+
+had_no_warnings();
diff --git a/t/hooks_in_pkg.t b/t/hooks_in_pkg.t
@@ -7,6 +7,7 @@ use lib 't/lib';
 our $VERSION = '9999.99.99_99'; # VERSION
 
 use Test::More;
+use Test::Warnings;
 use Test::Deep;
 
 use Rex::Commands;

diff --git a/t/hooks_in_rexfile.t b/t/hooks_in_rexfile.t
@@ -9,7 +9,8 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 BEGIN {
-  use Test::More tests => 8;
+  use Test::More tests => 9;
+  use Test::Warnings qw(:no_end_test had_no_warnings);
   use File::Temp;
   use Rex::Commands;
   use Rex::RunList;
@@ -52,3 +53,5 @@ is $after,                   1, 'after hook';
 is $after_all,               1, 'after ALL hook';
 is $after_task_finished,     1, 'after_task_finished hook';
 is $after_task_finished_all, 1, 'after_task_finished ALL hook';
+
+had_no_warnings();
diff --git a/t/hooks_in_rexfile_tasks_in_pkg.t b/t/hooks_in_rexfile_tasks_in_pkg.t
@@ -8,7 +8,8 @@ use warnings;
 our $VERSION = '9999.99.99_99'; # VERSION
 
 BEGIN {
-  use Test::More tests => 8;
+  use Test::More tests => 9;
+  use Test::Warnings qw(:no_end_test had_no_warnings);
   use lib 't/lib';
   use t::tasks::alien;
   use File::Temp;
@@ -52,3 +53,5 @@ is $after,                   1, 'after hook';
 is $after_all,               1, 'after ALL hook';
 is $after_task_finished,     1, 'after_task_finished hook';
 is $after_task_finished_all, 1, 'after_task_finished ALL hook';
+
+had_no_warnings;
diff --git a/t/host.t b/t/host.t
@@ -5,7 +5,8 @@ use warnings;
 
 our $VERSION = '9999.99.99_99'; # VERSION
 
-use Test::More tests => 10;
+use Test::More tests => 11;
+use Test::Warnings;
 
 use Rex::Commands::Host;