fix(service): duplicate lyric because the condition is always false

Richie-Z · Mar 25, 2024 · ec68d5a · ec68d5a
1 parent b1def91
commit ec68d5a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/services/translator.service.ts b/src/services/translator.service.ts
@@ -69,12 +69,11 @@ export class TranslatorService {
       if (JSON.stringify(translateSetting) !== JSON.stringify(settingService.getGoogleTranslateSetting()) ||
         JSON.stringify(kuroshiroSetting) !== JSON.stringify(settingService.getKuroshiroSetting())
       ) {
-        isAlreadyTranslated = false
         isSettingChanged = true
       }
 
       if (checkDomExists({ selector: "div.lyrics-lyrics-container" })) {
-        if (isAlreadyTranslated) return
+        if (isAlreadyTranslated && !isSettingChanged) return
         translatorService.convertLyric(isSettingChanged && isAlreadyTranslated ? this.originalLyric : undefined).then(() => {
           translatorService.renderLyric()
           isAlreadyTranslated = true;