Changes made by Haidra-org before deployment #3
Conversation
| <inline-svg href="assets/img/open-menu.svg" /> | ||
| <inline-svg href="assets/img/close-menu.svg" /> |
There was a problem hiding this comment.
Why this change? It's throughout the whole PR.
There was a problem hiding this comment.
The mobile experience hamburger menu did not seem to work, or if it did, it was in a non obvious way. This was my effort at making it work and work with a click away function to hide it
There was a problem hiding this comment.
Sorry, I misunderstood. This was so the site isn't bound to /, and would work on subdirs
There was a problem hiding this comment.
I meant the change that removes the leading / throughout the whole PR, sometimes replacing it with ./
There was a problem hiding this comment.
Yes sorry, I realized after. I answered above
There was a problem hiding this comment.
Ah, nevermind, I haven't read the comment that came with the PR. Anyway, it would be better to either stick to ./ or no prefix, not mixing it up.
| </li> | ||
| <li> | ||
| <a routerLink="/register" class="block py-2 pl-3 pr-4 text-white bg-purple-700 rounded lg:bg-transparent lg:text-purple-700 lg:p-0 dark:text-white" aria-current="page">{{'register_account' | transloco}}</a> | ||
| <a href="/register" class="block py-2 pl-3 pr-4 text-gray-500 bg-gray-400 rounded lg:bg-transparent lg:text-gray-500 lg:p-0 dark:text-white" aria-current="page">{{'register_account' | transloco}}</a> |
There was a problem hiding this comment.
Why this? We're not implementing registration before releasing it?
There was a problem hiding this comment.
Correct, we'll resolve this another time.
| <p class="mb-4" [innerHTML]="'quickstart.register_account' | transloco" > | ||
|
|
There was a problem hiding this comment.
This would be better reverted and the registerLink changed from {route: '/register'} to just /register, that way it will use href instead of routerLink.
There was a problem hiding this comment.
If you can demonstrate it works the same, that sounds fine to me
This PR is to help keep your original repo in sync. If you source any PRs back, there should be no merge conflict and your existing actions in your repo should therefore not interfere with our CI/CD scheme.
/news/endpoint to populate the new items/document/termsendpoint//register.