-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes made by Haidra-org before deployment #3
Changes from all commits
62c9863
dcdf02e
8542b82
0f540db
98c675a
be67902
2d3db15
19da2d6
cdfcbd3
1d01f4e
30ab18b
dad4928
e038af5
bf07964
acb74c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,34 +1,39 @@ | ||
<div class="wrapper" [class.dark]="darkMode()"> | ||
<div class="wrapper" [class.dark]="darkMode()" (click)="closeMobileMenu()"> | ||
<header class="fixed w-full"> | ||
<nav class="bg-white border-gray-200 py-2.5 dark:bg-gray-900"> | ||
<div class="flex flex-wrap items-center justify-between max-w-screen-xl px-4 mx-auto"> | ||
<a routerLink="/" class="flex items-center"> | ||
<img ngSrc="/assets/img/logo.png" class="h-6 mr-3 sm:h-9 w-auto" alt="{{'logo.alt' | transloco}}" height="455" width="393" priority/> | ||
<img ngSrc="./assets/img/logo.png" class="h-6 mr-3 sm:h-9 w-auto" alt="{{'logo.alt' | transloco}}" height="455" width="393" priority/> | ||
<span class="self-center text-xl font-semibold whitespace-nowrap dark:text-white">{{'app_title' | transloco}}</span> | ||
</a> | ||
<div class="flex items-end lg:order-2"> | ||
<button data-collapse-toggle="mobile-menu-2" type="button" | ||
class="inline-flex items-center p-2 ml-1 text-sm text-gray-500 rounded-lg lg:hidden hover:bg-gray-100 focus:outline-none focus:ring-2 focus:ring-gray-200 dark:text-gray-400 dark:hover:bg-gray-700 dark:focus:ring-gray-600" | ||
aria-controls="mobile-menu-2" aria-expanded="false"> | ||
aria-controls="mobile-menu-2" aria-expanded="false" | ||
(click)="toggleMobileMenu(); $event.stopPropagation()" | ||
> | ||
<span class="sr-only">{{'open_main_menu' | transloco}}</span> | ||
<inline-svg href="/assets/img/open-menu.svg" /> | ||
<inline-svg href="/assets/img/close-menu.svg" /> | ||
<inline-svg href="assets/img/open-menu.svg" /> | ||
<inline-svg href="assets/img/close-menu.svg" /> | ||
</button> | ||
</div> | ||
<div class="items-end justify-between hidden w-full lg:flex lg:w-auto lg:order-1" id="mobile-menu-2"> | ||
<ul class="flex flex-col mt-4 font-medium lg:flex-row lg:space-x-8 lg:mt-0"> | ||
<div class="items-end justify-between hidden w-full lg:flex lg:w-auto lg:order-1" id="mobile-menu-2" [class.hidden]="!showMobileMenu" (click)="$event.stopPropagation()"> | ||
<ul class="flex flex-col mt-4 font-medium border-b border-gray-300 lg:border-0 lg:flex-row lg:space-x-8 lg:mt-0 bg-gray-900"> | ||
<li> | ||
<a routerLink="/" class="block py-2 pl-3 pr-4 text-white bg-purple-700 rounded lg:bg-transparent lg:text-purple-700 lg:p-0 dark:text-white" aria-current="page">{{'home' | transloco}}</a> | ||
<a routerLink="/" class="block py-2 pl-3 pr-4 text-gray-500 bg-gray-400 rounded lg:bg-transparent lg:text-gray-500 lg:p-0 dark:text-white" aria-current="page">{{'home' | transloco}}</a> | ||
</li> | ||
<li> | ||
<a routerLink="/register" class="block py-2 pl-3 pr-4 text-white bg-purple-700 rounded lg:bg-transparent lg:text-purple-700 lg:p-0 dark:text-white" aria-current="page">{{'register_account' | transloco}}</a> | ||
<a href="/register" class="block py-2 pl-3 pr-4 text-gray-500 bg-gray-400 rounded lg:bg-transparent lg:text-gray-500 lg:p-0 dark:text-white" aria-current="page">{{'register_account' | transloco}}</a> | ||
</li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this? We're not implementing registration before releasing it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct, we'll resolve this another time. |
||
<li> | ||
<a routerLink="/news" class="block py-2 pl-3 pr-4 text-white bg-purple-700 rounded lg:bg-transparent lg:text-purple-700 lg:p-0 dark:text-white" aria-current="page">{{'news' | transloco}}</a> | ||
<a routerLink="/news" class="block py-2 pl-3 pr-4 text-gray-500 bg-gray-400 rounded lg:bg-transparent lg:text-gray-500 lg:p-0 dark:text-white" aria-current="page">{{'news' | transloco}}</a> | ||
</li> | ||
<li> | ||
<a routerLink="/faq" class="block py-2 pl-3 pr-4 text-white bg-purple-700 rounded lg:bg-transparent lg:text-purple-700 lg:p-0 dark:text-white" aria-current="page">{{'faq' | transloco}}</a> | ||
<a routerLink="/faq" class="block py-2 pl-3 pr-4 text-gray-500 bg-gray-400 rounded lg:bg-transparent lg:text-gray-500 lg:p-0 dark:text-white" aria-current="page">{{'faq' | transloco}}</a> | ||
</li> | ||
<li> | ||
<a href="/api/" class="block py-2 pl-3 pr-4 text-gray-500 bg-gray-400 rounded lg:bg-transparent lg:text-gray-500 lg:p-0 dark:text-white" aria-current="page">{{'api' | transloco}}</a> | ||
</li> | ||
</ul> | ||
</div> | ||
</div> | ||
|
@@ -91,7 +96,7 @@ <h3 class="mb-6 text-sm font-semibold text-gray-900 uppercase dark:text-white">{ | |
<h3 class="mb-6 text-sm font-semibold text-gray-900 uppercase dark:text-white">{{'documentation' | transloco}}</h3> | ||
<ul class="text-gray-500 dark:text-gray-400"> | ||
<li class="mb-4"> | ||
<a href="https://aihorde.net/api" class=" hover:underline" target="_blank">{{'rest_api' | transloco}}</a> | ||
<a href="https://aihorde.net/api/" class=" hover:underline" target="_blank">{{'rest_api' | transloco}}</a> | ||
</li> | ||
<li class="mb-4"> | ||
<a href="https://github.com/Haidra-Org/AI-Horde/blob/main/README_StableHorde.md#joining-the-horde" class="hover:underline" target="_blank">{{'join_horde' | transloco}}</a> | ||
|
@@ -105,7 +110,7 @@ <h3 class="mb-6 text-sm font-semibold text-gray-900 uppercase dark:text-white">{ | |
<hr class="my-6 border-gray-200 sm:mx-auto dark:border-gray-700 lg:my-8"> | ||
<div class="text-center"> | ||
<a href="#" class="flex items-center justify-center mb-5 text-2xl font-semibold text-gray-900 dark:text-white"> | ||
<img ngSrc="/assets/img/logo.png" class="h-6 mr-3 sm:h-9 w-auto" [alt]="'logo.alt' | transloco" height="455" width="393"/> | ||
<img ngSrc="./assets/img/logo.png" class="h-6 mr-3 sm:h-9 w-auto" [alt]="'logo.alt' | transloco" height="455" width="393"/> | ||
{{'app_title' | transloco}} | ||
</a> | ||
<span class="block text-sm text-center text-gray-500 dark:text-gray-400 built-with"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
header { | ||
z-index: 1000; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,18 +6,18 @@ <h2 class="mb-6 text-3xl font-extrabold tracking-tight text-gray-900 dark:text-w | |
<transloco key="quickstart" /> | ||
</h2> | ||
|
||
<p class="mb-4"> | ||
<transloco key="quickstart.register_account" [params]="{registerLink: {route: '/register'}}" /> | ||
<p class="mb-4" [innerHTML]="'quickstart.register_account' | transloco" > | ||
|
||
Comment on lines
+9
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would be better reverted and the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you can demonstrate it works the same, that sounds fine to me |
||
</p> | ||
<ul class="mb-2 space-y-2"> | ||
<li class="flex space-x-3"> | ||
<inline-svg href="/assets/img/li-checkbox.svg" /> | ||
<inline-svg href="assets/img/li-checkbox.svg" /> | ||
<span class="text-base"> | ||
<transloco key="quickstart.anonymous_api_key" /> | ||
</span> | ||
</li> | ||
<li class="flex space-x-3"> | ||
<inline-svg href="/assets/img/li-checkbox.svg" /> | ||
<inline-svg href="assets/img/li-checkbox.svg" /> | ||
<span class="text-base"> | ||
<transloco key="quickstart.explanation_api_key" [params]="{kudosExplanationLink: 'https://dbzer0.com/blog/the-kudos-based-economy-for-the-koboldai-horde/'}" /> | ||
</span> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? It's throughout the whole PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mobile experience hamburger menu did not seem to work, or if it did, it was in a non obvious way. This was my effort at making it work and work with a click away function to hide it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I misunderstood. This was so the site isn't bound to /, and would work on subdirs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the change that removes the leading
/
throughout the whole PR, sometimes replacing it with./
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry, I realized after. I answered above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nevermind, I haven't read the comment that came with the PR. Anyway, it would be better to either stick to
./
or no prefix, not mixing it up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair.