-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldexp implementation #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To continue with my review I require a suite of tests for ccm::ldexp that covers a set of data and edge cases for both double and float. Once those test cases have been made and passing I will continue with the review.
Also thanks for the contribution! I am excited to read more of your approach and implementation. ^^
Hey Bobby, what is the status of this PR currently? |
Working on some other stuff at the moment, I'll wrap up the rest of the trig functions and add the unit test in a week or two |
idk how to re-run the checks but i think i covered all the test cases |
Merged some changes I made on origin into your branch. Test will run now! ^^ |
Oh, I see why your failing to build. I made a change to the namespace of bits.hpp. It is no longer |
Crap I accidentally merged the PR. Give me a moment to fix this. |
equally as accurate as std::sin, 21-26x faster