Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldexp implementation #22

Merged
merged 9 commits into from
Apr 9, 2024
Merged

ldexp implementation #22

merged 9 commits into from
Apr 9, 2024

Conversation

GDBobby
Copy link
Contributor

@GDBobby GDBobby commented Mar 25, 2024

equally as accurate as std::sin, 21-26x faster

@Rinzii Rinzii added the enhancement New feature or request label Mar 25, 2024
@Rinzii Rinzii added this to the Road to v1.0.0 milestone Mar 25, 2024
@Rinzii Rinzii self-requested a review March 25, 2024 23:26
Copy link
Owner

@Rinzii Rinzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To continue with my review I require a suite of tests for ccm::ldexp that covers a set of data and edge cases for both double and float. Once those test cases have been made and passing I will continue with the review.

Also thanks for the contribution! I am excited to read more of your approach and implementation. ^^

@Rinzii
Copy link
Owner

Rinzii commented Mar 30, 2024

equally as accurate as std::sin, 21-26x faster

Hey Bobby, what is the status of this PR currently?

@GDBobby
Copy link
Contributor Author

GDBobby commented Mar 30, 2024

Working on some other stuff at the moment, I'll wrap up the rest of the trig functions and add the unit test in a week or two

@GDBobby
Copy link
Contributor Author

GDBobby commented Apr 9, 2024

idk how to re-run the checks but i think i covered all the test cases

@Rinzii
Copy link
Owner

Rinzii commented Apr 9, 2024

idk how to re-run the checks but i think i covered all the test cases

Merged some changes I made on origin into your branch. Test will run now! ^^

@Rinzii
Copy link
Owner

Rinzii commented Apr 9, 2024

Oh, I see why your failing to build. I made a change to the namespace of bits.hpp. It is no longer ccm::helpers but now ccm::support. Should be trivial to fix.

@Rinzii Rinzii merged commit 03f2488 into Rinzii:dev Apr 9, 2024
0 of 3 checks passed
@Rinzii
Copy link
Owner

Rinzii commented Apr 9, 2024

Crap I accidentally merged the PR. Give me a moment to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants