Convert CLI handling to use Kong #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should also fix a bug where non-HTTP 200 responses are not caught and result in a cryptic error later in the exchange process
* Pass client through context. This would normally be frowned upon but we know we will only be using OAuth2's APIs to interact with Okta anyway. * Implement oauth2.TokenSource on TokenSet, which removes the need to manually construct *oauth2.Token.
The config shouldn't "know" anything about the minutae of the token it is receiving.
Takes the HandlePendingSession function much simpler
This was necessary due a bug in Go (golang/go#14514) that was resolved in Go 1.8.
This will be reimplemented at some point in the future, but this has not been working since 85f224a and attempting to use it results in a run-time panic.
The UserInfo endpoint for Okta is standards-compliant, so we should use a standards-compliant library to access it
Instead of using AWS authentication for Vault, users should be instructed to use the Hashicorp Vault extension for AWS Lambda; KeyConjurer's Lambda functions are not made aware of any authentication details. https://developer.hashicorp.com/vault/docs/platform/aws/lambda-extension
VAULT_SECRET_PATH conflicts with the Lambda extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kong requires fewer tricks (except for that weird reflection it uses) and is a lot easier to scan with less global setup required in
initblocks.