Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleNotFoundError: No module named 'minifier' #622

Closed
MattReimer opened this issue Nov 1, 2022 · 2 comments
Closed

ModuleNotFoundError: No module named 'minifier' #622

MattReimer opened this issue Nov 1, 2022 · 2 comments
Assignees
Labels
🐛 bug Something isn't working 🔥 BLOCKED Priority#1. Can't Proceed until fixed. (Use sparingly)

Comments

@MattReimer
Copy link
Member

We have an issue with a small but crucial pip install that is currently out of date:

The HTML5print module (last released in 2016) requires the slimit module (last released in 2013) and this slimit module is broken

  • html5print has an open issue for this here
  • slimit has a number of fixes that make it work with Python3 but the developer is unresponsive

A temporary fix to unblock developers:

./venv/bin/pip3 uninstall slimit
./venv/bin/pip3 install pip install git+https://github.com/rspivak/slimit.git@3533eba9ad5b39f3a015ae6269670022ab310847

A better fix

Neither html5print nor slimit are being used and we only use these modules to beautify our html output. I think we could get around this issue completely by finding a better, more up-to-date module to do this work.

@MattReimer MattReimer added 🔥 BLOCKED Priority#1. Can't Proceed until fixed. (Use sparingly) 🐛 bug Something isn't working labels Nov 1, 2022
@MattReimer MattReimer self-assigned this Nov 1, 2022
@philipbaileynar
Copy link
Contributor

If we skip beautifying our HTML, can we just use Visual Studio Code "Format Document" within the team when we need to make sense of the HTML?

I vote to remove these libraries immediately and take our time finding a replacement.

@MattReimer
Copy link
Member Author

Agreed. I originally thought this was used for XML prettifying (which we actually need) but it's not. @jtgilbert , this is only used in the rs_report and that's your next stop right? Can you pull it out please?

@MattReimer MattReimer assigned jtgilbert and unassigned MattReimer Nov 2, 2022
jtgilbert added a commit that referenced this issue Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🔥 BLOCKED Priority#1. Can't Proceed until fixed. (Use sparingly)
Projects
None yet
Development

No branches or pull requests

3 participants