Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TcBlackCLI work from every directory and with relative paths #19

Open
Roald87 opened this issue Jun 22, 2020 · 4 comments
Open

Make TcBlackCLI work from every directory and with relative paths #19

Roald87 opened this issue Jun 22, 2020 · 4 comments
Labels
bug Something isn't working cli Issues related to TcBlackCLI enhancement New feature or request

Comments

@Roald87
Copy link
Owner

Roald87 commented Jun 22, 2020

Currently TcBlack.exe only works under the following conditions:

  1. build.log needs to be present when executed in non-safe mode.
  2. TcBlack.exe is executed directly from its own folder
  3. All files which should be reformatted are entered with their full paths.
@Roald87 Roald87 added bug Something isn't working enhancement New feature or request labels Jun 22, 2020
@Roald87 Roald87 added this to the Version 0.2 milestone Jun 22, 2020
@Roald87 Roald87 removed the bug Something isn't working label Jun 22, 2020
@Roald87 Roald87 modified the milestones: Version 0.2, Version 0.5 Jun 22, 2020
@Roald87 Roald87 added the bug Something isn't working label Jun 23, 2020
@Roald87 Roald87 added the cli Issues related to TcBlackCLI label Apr 4, 2021
@Doctornunu
Copy link

Hi!

Not sure if this is the right place to ask but I fiddled around a bit with the formatter and I couldn't seem to get the formatting to work on the implementation parts of the POUs.
I tried to format the .plcproj as well as the .TcPOUs by themselves and I tried all command combinations as well as different directories.

Not quite sure if there's anything I'm missing here as I didn't get any error messages.
I've attached a copy of the .TcPOU that I've tried on.

TcPOU.zip

@Roald87
Copy link
Owner Author

Roald87 commented May 21, 2021

Hi @Doctornunu. Formatting of the implementation part of the POU is not implemented yet. It is planned for a future milestone. See also #40.

@Doctornunu
Copy link

Oh, I was under the impression that this wasn't the case for "programs" / POUs. I interpreted this quote from the manual as it was only the case for function blocks, functions etc :

Note: Currently TcBlack only formats the declaration part of function blocks, functions, methods, properties and interfaces. Formatting of the implementation is planned for a future release.

Thanks for the answer though, I would love to contribute to the project once (or if) I get .NET + C# running properly in VSCode.

@Roald87
Copy link
Owner Author

Roald87 commented May 22, 2021

Thanks for noting that! I've changed it now.

@Roald87 Roald87 changed the title Make TcBlack work from every directory and with relative paths Make TcBlackCLI work from every directory and with relative paths May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Issues related to TcBlackCLI enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants