Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setLedDriverMode(uint8_t mode) doesn't set LedDriverMode for all channels #32

Closed
khangtranduc opened this issue Jan 18, 2024 · 5 comments · Fixed by #33
Closed

setLedDriverMode(uint8_t mode) doesn't set LedDriverMode for all channels #32

khangtranduc opened this issue Jan 18, 2024 · 5 comments · Fixed by #33
Assignees
Labels
bug Something isn't working

Comments

@khangtranduc
Copy link

Only channels 0-11 are set to the desired mode using this method, with channels 12-15 not being set to desired mode.
Manual setting using setLedDriverMode(uint8_t channel, uint8_t mode) for every channel (from 0 through 15) works though.

@RobTillaart RobTillaart self-assigned this Jan 18, 2024
@RobTillaart RobTillaart added the bug Something isn't working label Jan 18, 2024
@RobTillaart
Copy link
Owner

Thanks for reporting this issue.
I will look into it asap however it might take a few days.

@RobTillaart
Copy link
Owner

Quick look at the code and found a possible cause.

Can you change line 520 in the .cpp file?
Change 3 to 4 in the for loop so it becomes:

for (int reg = 0; reg < 4; reg++)
  {
    writeLedOut(reg, mask);
  }

Please let me know if that fixes the issue.

@khangtranduc
Copy link
Author

Wow, thank you for the prompt response! I will try that later once I'm back.

@khangtranduc
Copy link
Author

Yes it works!

@RobTillaart
Copy link
Owner

new version 0.6.0 released with fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants