Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to generated docs #103

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Improvements to generated docs #103

merged 2 commits into from
Nov 15, 2024

Conversation

00xc
Copy link
Contributor

@00xc 00xc commented Nov 8, 2023

  • Fix markdown for Errors and Panics sections.
  • Properly format field names.

@00xc
Fix generated documentation sections
d27fc62 
Make sure the Errors and Panics sections in the generated docs are
displayed properly.
@00xc
Properly format field names in generated docs
1b300fe
@Robbepop
Copy link
Owner

Robbepop commented Nov 8, 2023

Thank you for the improvements!

@00xc
Copy link
Contributor Author

00xc commented Nov 22, 2023

Hi, could you review the changes? I believe the test failures are unrelated.

@00xc
Copy link
Contributor Author

00xc commented Nov 15, 2024

Ping, could you merge this?

Robbepop
Robbepop approved these changes Nov 15, 2024
View reviewed changes
Copy link
Owner

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@00xc hey, I am very sorry. I didn't mean to ignore this PR. Thanks a lot for the improvements! LGTM. :)

@Robbepop Robbepop merged commit f622172 into Robbepop:master Nov 15, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@00xc @Robbepop