Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EECI 6095: Update dependencies #53

Merged
merged 19 commits into from
Nov 20, 2023
Merged

EECI 6095: Update dependencies #53

merged 19 commits into from
Nov 20, 2023

Conversation

rgychiu
Copy link
Contributor

@rgychiu rgychiu commented Nov 18, 2023

  • The repo has been accumulating some dependabot alerts and has a decent amount of outdated dependencies. This PR updates dependencies to semver-compatible versions using npm update --save or installs a later version
    • Seems like there's no vulnerabilities! 🎉
  • Updates the error handling/logging:
    • Newer versions of Typescript introduced and changed the error catching type to be unknown instead of any, which caused some compile time errors.
    • Some error types also have circular JSON structures which obscured the actual error cause, which is addressed in this PR by logging the error trace and message instead of the whole objects
  • Updates test cases to be compatible with version changes

Copy link

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@rgychiu rgychiu marked this pull request as ready for review November 18, 2023 01:52
Base automatically changed from eeci-6094-test-workflow to master November 20, 2023 18:36
@rgychiu rgychiu dismissed cliffchapmanrbx’s stale review November 20, 2023 18:36

The base branch was changed.

@rgychiu rgychiu merged commit b03f3ff into master Nov 20, 2023
3 checks passed
@rgychiu rgychiu deleted the eeci-6095-update-errors branch November 20, 2023 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants