Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/dribbler encoders 2023. Dribbler ball detection now works with new encoders #80

Merged
merged 9 commits into from
Jul 3, 2023

Conversation

emielsteerneman
Copy link
Member

Most important changes:

  • Dribbler ball detection now works with new encoders (tested with 3 different robots)
  • Dribbler encoder now counts up again from 0, instead of down from 65536
  • Moved dribbler ball detection to control loop, to prevent spikes in dribbler encoder measurements (and tons of unnecessary calculations)
  • Reverted dribbler encoder back to 32 bits just to be sure
  • Tons of naming conventions and other cleanups

Copy link
Contributor

@skaeringur97 skaeringur97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, saw the test results also and they look very nice.

@emielsteerneman emielsteerneman merged commit 90f2950 into development Jul 3, 2023
@supertom01 supertom01 deleted the update/dribbler_encoders_2023 branch August 23, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants