Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate web_video_server into a component and an executable #168

Merged
merged 2 commits into from
Nov 2, 2024

Commits on Oct 28, 2024

  1. Separate web_video_server into a component and an executable

    The [ROS 2 (Humble)
    docs](https://docs.ros.org/en/humble/Concepts/Intermediate/About-Composition.html#writing-a-component)
    recommend writing applications as components:
    
    > By making the process layout a deploy-time decision the user can
    > choose between:
    >
    > * running multiple nodes in separate processes with the benefits
    > of process/fault isolation as well as easier debugging of individual
    > nodes and
    >
    > * running multiple nodes in a single process with the lower overhead
    > and optionally more efficient communication.
    
    The default deployment scheme for the `web_video_server` node remains
    the same: i.e., using
    `ros2 run web_video_server web_video_server {parameter-args-here}`.
    
    Having a component library available adds flexibility for users,
    particularly for those users looking to use intra-process memory
    for published camera topics and the web video server.
    jwdinius committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cea8e8e View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Resolve PR RobotWebTools#168 comments

    * Rename exported library
    * Move cleanup_timer_ initialization to WebVideoServer constructor
    * Remove setup_cleanup_inactive_streams function and references
    jwdinius committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    0684105 View commit details
    Browse the repository at this point in the history