-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Dockerfile optimizations #288
base: main
Are you sure you want to change the base?
Minor Dockerfile optimizations #288
Conversation
Hm, odd that ROS-Industrial CI is now breaking. Debugging ... Hm, so ROS-industrial CI is looking for |
As a note, as expected, industrial CI does work if we force it to run on "humble" (where mavros is available through rosdep), but fails for "rolling" (and presumably "jazzy") |
- IMAGE: rolling-ci | ||
ROS_DISTRO: rolling | ||
- IMAGE: humble-ci | ||
ROS_DISTRO: humble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted, industrial CI tries to install mavros viaapt
, which is currently not available for rolling (#248).
CI does work if we force it to use Humble, for which there's a binary image.
Note this is just the ros_industrial CI stage, not building the Docker images (where Mavros is built from source for rolling/jazzy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into that. Because we know it's an issue with MAVROS, It's not a big deal if the CI fails in this PR. We can just update the CI stage in #241 to use the new mavros
stage.
Changes Made
Cleaned up and focused version of #226.
An opinionated cleanup of the dockerfile. Includes:
In the "ci" image:
*/package.xml
(requires the recent "copy --parent" syntax in the Dockerfile) andblue.repos
into theci
image, rather than the full contents of this repo. I believe this prevents changes to e.g. files in.docker/
from breaking cache.vcs import < blue.repos
so rosdep dependencies for those packages are also installed in the CI image.In the "robot" image:
This doesn't include some of the more opinionated hadolint changes (e.g. gosu, etc). This PR is focused on moving relatively static steps (apt-get) above cache-breaking changes (pulling files from the local filesystem)
Associated Issues
None
Testing
Completed "joystick teleoperation" demo with built images in
rolling
andjazzy