Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the default option to NO in the not trusted certificate dialog #2916

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix: Set the default option to NO in the not trusted certificate dialog #2916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbf1b5c
improve not trusted certificate message
jeanfbrito Jul 12, 2024
01aa1c5
make NO the default to not trusted certificates dialog
jeanfbrito Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"certificateError": {
"title": "Certificate error",
"message": "Do you trust certificate from \"{{- issuerName}}\"?",
"message": "Do you trust certificate from \"{{- issuerName}}\"? Only click 'Yes' if you really trust this certificate. If you are unsure, contact your IT or security team before clicking on 'Yes'.",
"yes": "Yes",
"no": "No"
},
Expand Down
2 changes: 1 addition & 1 deletion src/i18n/pt-BR.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"certificateError": {
"title": "Erro de Certificado",
"message": "Você confia no certificado de \"{{- issuerName}}\"?",
"message": "Você confia no certificado de \"{{- issuerName}}\"? Clique em 'Sim' apenas se você realmente confiar neste certificado. Se estiver em dúvida, entre em contato com sua equipe de TI ou segurança antes de clicar em 'Sim'.",
"yes": "Sim",
"no": "Não"
},
Expand Down
1 change: 1 addition & 0 deletions src/ui/main/dialogs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export const askForCertificateTrust = async (
t('dialog.certificateError.no'),
],
cancelId: 1,
defaultId: 1,
}
);

Expand Down
Loading