forked from FAIR-Chem/fairchem
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncertainty #59
Open
AlexDuvalinho
wants to merge
30
commits into
main
Choose a base branch
from
uncertainty
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Uncertainty #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vict0rsch
reviewed
Oct 8, 2024
@@ -41,7 +42,7 @@ | |||
conda activate {env} | |||
fi | |||
{wandb_offline} | |||
srun --gpus-per-task=1 --output={output} {python_command} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone knows why this disappeared?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we continue the work done on depfaenet and deup-depfaenet, integrating it into the active learning pipeline.
Aims:
(1) have a trained DepFAENet model fine-tuned on selected adsorbates, to predict the adsorption energies for catalyst-adsorbate pairs generated by GFlowNet
(2) have a deup-dataset which the intermediate representations of the above model, to train a Gaussian Process that measures uncertainty
(3) have a (v0) deup-depfaenet model that predicts uncertainty of the core DepFAENet model
Main changes of this PR are:
Information on best checkpoints are included in https://www.notion.so/Coding-Probabilistic-Surrogate-Model-328aece28af948f686fa91a2623d8635?pvs=4
From the uncertainty-depfaenet branch:
CAREFUL: only store graph-level rep in deup-dataset from now on. Need to change it if we want to perform MC dropout again (related to deup-faenet)