-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate never released #120
Comments
Sorry about this! I thought I had resolved any retain cycles. I will check out the sample app and hopefully resolve. |
Hi, Adam! |
I'd really like to use this library also, but a retain cycle in the delegate makes this unusable. Hope to see this resolved soon! |
I think I have observed the same issue in I still haven’t figured out the retain cycle though. 🙁 |
Oh, apparently this issue is already being investigated in #102. |
@0xced your hot fix is help me. Need to call |
Any news? |
Hi everyone and thank you for this library!
But, after a day of research I found really sad bug:
If we do any database modifications after "performFetch" - delegate will be retained somewhere and won't be released.
It brings a lot of pain and makes the library unusable =(
I have slightly edited sample project to make this bug more obviously:
http://rgho.st/8b9RLZN6L
Have a look on "viewDidLoad" in "ExampleTableViewController" and try to comment and uncomment calling of "writeObjects" before and after "performFetch". Then press back and you will see that "ExampleTableViewController" will never released.
The text was updated successfully, but these errors were encountered: