From 027041cc60d70a904ce35860175009f54df6ad0a Mon Sep 17 00:00:00 2001
From: Francisco Tobar <francisco.tobar@iovlabs.org>
Date: Wed, 27 Nov 2024 10:00:13 -0600
Subject: [PATCH 1/2] refactor: disabled if builder not operational

---
 .../builder/BuilderRewardsSettingsForm.tsx    | 41 ++++++++++++++-----
 .../context/BuilderSettingsContext.tsx        |  4 ++
 .../settings/builder/hooks/index.ts           |  1 +
 .../hooks/useGetIsBuilderOperational.ts       | 17 ++++++++
 .../settings/builder/index.ts                 |  2 +
 5 files changed, 55 insertions(+), 10 deletions(-)
 create mode 100644 src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts

diff --git a/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx b/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
index c102e38b..5a9298e2 100644
--- a/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
+++ b/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
@@ -7,8 +7,9 @@ import { FC, useEffect, useState } from 'react'
 import { useForm } from 'react-hook-form'
 import { GoRocket } from 'react-icons/go'
 import { z } from 'zod'
-import { percentageToWei } from '../utils'
+import { percentageToWei } from '@/app/collective-rewards/settings/utils'
 import { useBuilderSettingsContext } from './context'
+import { Popover } from '@/components/Popover'
 
 const formSchema = z.object({
   reward: z
@@ -39,9 +40,10 @@ const formSchema = z.object({
 export const BuilderRewardsSettingsForm: FC = () => {
   const router = useRouter()
   const [backButtonName, setBackButtonName] = useState('Cancel')
-  const {
+  let {
     current: { refetch, isLoading: isCurrentRewardsLoading },
     update: { isSuccess, setNewReward, isPending },
+    isBuilderOperational,
   } = useBuilderSettingsContext()
 
   const form = useForm<z.infer<typeof formSchema>>({
@@ -84,7 +86,12 @@ export const BuilderRewardsSettingsForm: FC = () => {
                 {isCurrentRewardsLoading ? (
                   <LoadingSpinner />
                 ) : (
-                  <FormInput placeholder="0 ... 100 %" inputMode="decimal" {...field} />
+                  <FormInput
+                    placeholder="0 ... 100 %"
+                    inputMode="decimal"
+                    {...field}
+                    disabled={!isBuilderOperational}
+                  />
                 )}
               </FormControl>
               <FormMessage />
@@ -92,14 +99,28 @@ export const BuilderRewardsSettingsForm: FC = () => {
           )}
         ></FormField>
         <div className="flex flex-row justify-start gap-4">
-          <Button
-            startIcon={<GoRocket />}
-            disabled={!isDirty || !isValid}
-            buttonProps={{ type: 'submit' }}
-            loading={isPending}
+          <Popover
+            content={
+              <div className="text-[12px] font-bold mb-1">
+                <p data-testid="adjustBackerRewardPctTooltip">
+                  You need to be operational to adjust your backer reward %
+                </p>
+              </div>
+            }
+            size="small"
+            position="top"
+            trigger="hover"
+            disabled={isBuilderOperational}
           >
-            Save changes
-          </Button>
+            <Button
+              startIcon={<GoRocket />}
+              disabled={!isDirty || !isValid || !isBuilderOperational}
+              buttonProps={{ type: 'submit' }}
+              loading={isPending}
+            >
+              Save changes
+            </Button>
+          </Popover>
           <Button
             variant="secondary"
             onClick={() => {
diff --git a/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx b/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
index e528c20a..8db27951 100644
--- a/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
+++ b/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
@@ -8,11 +8,13 @@ import {
 import { createContext, FC, ReactNode, useContext } from 'react'
 import { Address } from 'viem'
 import { useAccount } from 'wagmi'
+import { useGetIsBuilderOperational } from '@/app/collective-rewards/settings'
 
 type BackerRewardsPercentageContext = {
   update: SetBackerRewardsForBuilder
   current: BackerRewardResponse
   rewardPercentageToApply: RewardPercentageToApply
+  isBuilderOperational?: boolean
 }
 
 const BuilderSettingsContext = createContext<BackerRewardsPercentageContext>(
@@ -26,11 +28,13 @@ export const BuilderSettingsProvider: FC<{ children: ReactNode }> = ({ children
   const current = useGetBackerRewardsForBuilder(address as Address)
   const update = useSetBackerRewardsForBuilder()
   const rewardPercentageToApply = useGetRewardPercentageToApply(address as Address)
+  const { data: isBuilderOperational } = useGetIsBuilderOperational(address as Address)
 
   const contextValue: BackerRewardsPercentageContext = {
     update,
     current,
     rewardPercentageToApply,
+    isBuilderOperational,
   }
 
   return <BuilderSettingsContext.Provider value={contextValue}>{children}</BuilderSettingsContext.Provider>
diff --git a/src/app/collective-rewards/settings/builder/hooks/index.ts b/src/app/collective-rewards/settings/builder/hooks/index.ts
index 880f1170..5f40d8f4 100644
--- a/src/app/collective-rewards/settings/builder/hooks/index.ts
+++ b/src/app/collective-rewards/settings/builder/hooks/index.ts
@@ -1 +1,2 @@
 export * from './useBuilderConfig'
+export * from './useGetIsBuilderOperational'
diff --git a/src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts b/src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts
new file mode 100644
index 00000000..54b69a31
--- /dev/null
+++ b/src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts
@@ -0,0 +1,17 @@
+import { AVERAGE_BLOCKTIME } from '@/lib/constants'
+import { BackersManagerAddress } from '@/lib/contracts'
+import { useReadContract } from 'wagmi'
+import { BuilderRegistryAbi } from '@/lib/abis/v2/BuilderRegistryAbi'
+import { Address } from 'viem'
+
+export const useGetIsBuilderOperational = (builder: Address) => {
+  return useReadContract({
+    address: BackersManagerAddress,
+    abi: BuilderRegistryAbi,
+    functionName: 'isBuilderOperational',
+    args: [builder],
+    query: {
+      refetchInterval: AVERAGE_BLOCKTIME,
+    },
+  })
+}
diff --git a/src/app/collective-rewards/settings/builder/index.ts b/src/app/collective-rewards/settings/builder/index.ts
index 819e51f7..c4afc213 100644
--- a/src/app/collective-rewards/settings/builder/index.ts
+++ b/src/app/collective-rewards/settings/builder/index.ts
@@ -1,3 +1,5 @@
 export * from './BuilderRewardsSettingsMetrics'
 export * from './BuilderRewardsSettingsForm'
 export * from './BuilderSettings'
+export * from './context'
+export * from './hooks'

From 5d237870fffb1fe7b1fa18de92e971772c60f6a4 Mon Sep 17 00:00:00 2001
From: Francisco Tobar <francisco.tobar@iovlabs.org>
Date: Wed, 27 Nov 2024 10:29:13 -0600
Subject: [PATCH 2/2] refactor: pr comments

---
 .../builder/BuilderRewardsSettingsForm.tsx      |  2 +-
 .../builder/context/BuilderSettingsContext.tsx  | 11 +++++++----
 .../settings/builder/hooks/index.ts             |  1 -
 .../builder/hooks/useGetIsBuilderOperational.ts | 17 -----------------
 .../shared/components/Table/TableCells.tsx      | 11 +++--------
 .../utils/getMostAdvancedProposal.ts            |  4 ++--
 6 files changed, 13 insertions(+), 33 deletions(-)
 delete mode 100644 src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts

diff --git a/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx b/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
index 5a9298e2..d13d4e4a 100644
--- a/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
+++ b/src/app/collective-rewards/settings/builder/BuilderRewardsSettingsForm.tsx
@@ -40,7 +40,7 @@ const formSchema = z.object({
 export const BuilderRewardsSettingsForm: FC = () => {
   const router = useRouter()
   const [backButtonName, setBackButtonName] = useState('Cancel')
-  let {
+  const {
     current: { refetch, isLoading: isCurrentRewardsLoading },
     update: { isSuccess, setNewReward, isPending },
     isBuilderOperational,
diff --git a/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx b/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
index 8db27951..b41def17 100644
--- a/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
+++ b/src/app/collective-rewards/settings/builder/context/BuilderSettingsContext.tsx
@@ -8,13 +8,14 @@ import {
 import { createContext, FC, ReactNode, useContext } from 'react'
 import { Address } from 'viem'
 import { useAccount } from 'wagmi'
-import { useGetIsBuilderOperational } from '@/app/collective-rewards/settings'
+import { useBuilderContext } from '@/app/collective-rewards/user'
+import { isBuilderOperational } from '@/app/collective-rewards/utils'
 
 type BackerRewardsPercentageContext = {
   update: SetBackerRewardsForBuilder
   current: BackerRewardResponse
   rewardPercentageToApply: RewardPercentageToApply
-  isBuilderOperational?: boolean
+  isBuilderOperational: boolean
 }
 
 const BuilderSettingsContext = createContext<BackerRewardsPercentageContext>(
@@ -24,17 +25,19 @@ const BuilderSettingsContext = createContext<BackerRewardsPercentageContext>(
 export const useBuilderSettingsContext = () => useContext(BuilderSettingsContext)
 
 export const BuilderSettingsProvider: FC<{ children: ReactNode }> = ({ children }) => {
+  const { getBuilderByAddress } = useBuilderContext()
   const { address } = useAccount()
   const current = useGetBackerRewardsForBuilder(address as Address)
   const update = useSetBackerRewardsForBuilder()
   const rewardPercentageToApply = useGetRewardPercentageToApply(address as Address)
-  const { data: isBuilderOperational } = useGetIsBuilderOperational(address as Address)
+  const builder = getBuilderByAddress(address as Address)
+  const isOperational = builder ? isBuilderOperational(builder.stateFlags) : false
 
   const contextValue: BackerRewardsPercentageContext = {
     update,
     current,
     rewardPercentageToApply,
-    isBuilderOperational,
+    isBuilderOperational: isOperational,
   }
 
   return <BuilderSettingsContext.Provider value={contextValue}>{children}</BuilderSettingsContext.Provider>
diff --git a/src/app/collective-rewards/settings/builder/hooks/index.ts b/src/app/collective-rewards/settings/builder/hooks/index.ts
index 5f40d8f4..880f1170 100644
--- a/src/app/collective-rewards/settings/builder/hooks/index.ts
+++ b/src/app/collective-rewards/settings/builder/hooks/index.ts
@@ -1,2 +1 @@
 export * from './useBuilderConfig'
-export * from './useGetIsBuilderOperational'
diff --git a/src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts b/src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts
deleted file mode 100644
index 54b69a31..00000000
--- a/src/app/collective-rewards/settings/builder/hooks/useGetIsBuilderOperational.ts
+++ /dev/null
@@ -1,17 +0,0 @@
-import { AVERAGE_BLOCKTIME } from '@/lib/constants'
-import { BackersManagerAddress } from '@/lib/contracts'
-import { useReadContract } from 'wagmi'
-import { BuilderRegistryAbi } from '@/lib/abis/v2/BuilderRegistryAbi'
-import { Address } from 'viem'
-
-export const useGetIsBuilderOperational = (builder: Address) => {
-  return useReadContract({
-    address: BackersManagerAddress,
-    abi: BuilderRegistryAbi,
-    functionName: 'isBuilderOperational',
-    args: [builder],
-    query: {
-      refetchInterval: AVERAGE_BLOCKTIME,
-    },
-  })
-}
diff --git a/src/app/collective-rewards/shared/components/Table/TableCells.tsx b/src/app/collective-rewards/shared/components/Table/TableCells.tsx
index d51c6cd2..932d5f50 100644
--- a/src/app/collective-rewards/shared/components/Table/TableCells.tsx
+++ b/src/app/collective-rewards/shared/components/Table/TableCells.tsx
@@ -207,17 +207,12 @@ export const ActionCell: FC<ActionCellProps> = ({ tableHeader: { className }, bu
     [selections, builderAddress, isPreallocated],
   )
 
-  const isBuilderOperational = useMemo(() => {
+  const isOperational = useMemo(() => {
     if (!builder) {
       console.log('Builder not found in selection') // TODO: handle this case better
       return
     }
-    return (
-      builder.stateFlags &&
-      builder.stateFlags.kycApproved &&
-      builder.stateFlags.communityApproved &&
-      !builder.stateFlags.paused
-    )
+    return isBuilderOperational(builder.stateFlags)
   }, [builder])
 
   const selectBuilder = () => {
@@ -228,7 +223,7 @@ export const ActionCell: FC<ActionCellProps> = ({ tableHeader: { className }, bu
     <TableCell className={cn(className, 'border-solid align-center')}>
       <Button
         variant={isSelected ? 'white' : 'secondary'}
-        disabled={!isBuilderOperational || isPreallocated}
+        disabled={!isOperational || isPreallocated}
         onClick={selectBuilder}
         className="white text-center"
       >
diff --git a/src/app/collective-rewards/utils/getMostAdvancedProposal.ts b/src/app/collective-rewards/utils/getMostAdvancedProposal.ts
index 3d1d9bfe..4fda3a4e 100644
--- a/src/app/collective-rewards/utils/getMostAdvancedProposal.ts
+++ b/src/app/collective-rewards/utils/getMostAdvancedProposal.ts
@@ -4,8 +4,8 @@ import { ProposalState } from '@/shared/types'
 
 const inactiveProposalsStates = [ProposalState.Canceled, ProposalState.Defeated, ProposalState.Expired]
 const isActive = (state: ProposalState) => !inactiveProposalsStates.includes(state)
-const isBuilderActive = (status?: BuilderStateFlags) =>
-  !status || status.activated || status.communityApproved
+const isBuilderActive = (stateFlags?: BuilderStateFlags) =>
+  !stateFlags || stateFlags.activated || stateFlags.communityApproved
 
 export const getMostAdvancedProposal = (
   proposalsEvent: CreateBuilderProposalEventLog[],