SporeModManager: fix memory leaks in SporeMod::InstallSporeMod() and …

…SporeModManager::UpdateMod()
Rosalie241 · Jul 24, 2022 · 7be6cc4 · 7be6cc4
1 parent 31b0a1e
commit 7be6cc4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/SporeModManager/SporeModManager.cpp b/SporeModManager/SporeModManager.cpp
@@ -108,6 +108,8 @@ bool SporeModManager::UpdateMod(std::filesystem::path path)
         // make sure we have the modapi dll that the mod requires
         if (!FileVersion::CheckIfCoreLibMatchesVersion(sporeModInfo.MinimumModAPILibVersion, sporeModInfo.Name))
         {
+            free(modInfoFileBuffer);
+            Zip::CloseFile(zipFile);
             return false;
         }
 

diff --git a/SporeModManager/SporeModManagerHelpers/SporeMod.cpp b/SporeModManager/SporeModManagerHelpers/SporeMod.cpp
@@ -135,12 +135,16 @@ bool SporeMod::InstallSporeMod(std::filesystem::path path)
     // already installed
     if (IsModAlreadyInstalled(sporeModInfo.UniqueName))
     {
+        free(modInfoFileBuffer);
+        Zip::CloseFile(zipFile);
         return false;
     }
 
     // make sure we have the modapi dll that the mod requires
     if (!FileVersion::CheckIfCoreLibMatchesVersion(sporeModInfo.MinimumModAPILibVersion, sporeModInfo.Name))
     {
+        free(modInfoFileBuffer);
+        Zip::CloseFile(zipFile);
         return false;
     }
 
@@ -165,6 +169,8 @@ bool SporeMod::InstallSporeMod(std::filesystem::path path)
             UI::AskUserInput(inputText, userAnswer, false);
             if (!userAnswer)
             {
+                free(modInfoFileBuffer);
+                Zip::CloseFile(zipFile);
                 return false;
             }
         }
@@ -230,6 +236,8 @@ bool SporeMod::InstallSporeMod(std::filesystem::path path)
     // file collision detection
     if (CheckIfOtherModContainsFiles(installedSporeMod.InstalledFiles))
     {
+        free(modInfoFileBuffer);
+        Zip::CloseFile(zipFile);
         return false;
     }