Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark internal attributes as private #130

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Mark internal attributes as private #130

merged 1 commit into from
Sep 19, 2023

Conversation

alihamdan
Copy link
Member

To avoid someone typing:

Control.DEFAULT_ALPHA = 2000
control = Control("constant", 220, 225, 235, 240)  # no alpha provided

and expecting to see the new default value.

I'll update the engine as well.

@alihamdan alihamdan added the enhancement New feature or request label Sep 19, 2023
@alihamdan alihamdan self-assigned this Sep 19, 2023
@alihamdan alihamdan merged commit 2333f91 into develop Sep 19, 2023
@alihamdan alihamdan deleted the private-attrs branch September 19, 2023 12:56
@benoit9126 benoit9126 mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saelyos Saelyos Saelyos approved these changes

@benoit9126 benoit9126 Awaiting requested review from benoit9126

Assignees

@alihamdan alihamdan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alihamdan @Saelyos