Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed the following bugs:
network_from_dict
max_loading
for linesmax_loading
for transformerstap
for transformerssingle
andcenter
transformer types to proper vector groupsmax_current
,conductor_type
, andinsulator_type
of line parametersThese bugs were found with testing more comprehensive JSON files. I added files for all JSON versions and the corresponding file generator scripts.
I also added a test to ensure these files do not get modified by mistake when refactoring the code base.