Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in JSON serialization #291

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Fix bugs in JSON serialization #291

merged 3 commits into from
Dec 1, 2024

Conversation

alihamdan
Copy link
Member

@alihamdan alihamdan commented Nov 29, 2024

Found and fixed the following bugs:

  • Fix version checks in network_from_dict
  • Emit proper warning for older versions
  • Add missing max_loading for lines
  • Add missing max_loading for transformers
  • Add missing tap for transformers
  • Fix error due to sorting of line parameters and transformer parameters with heterogeneous ID types
  • Fix conversion of single and center transformer types to proper vector groups
  • Fix upgrading of max_current, conductor_type, and insulator_type of line parameters

These bugs were found with testing more comprehensive JSON files. I added files for all JSON versions and the corresponding file generator scripts.

I also added a test to ensure these files do not get modified by mistake when refactoring the code base.

@alihamdan alihamdan added the bug Something isn't working label Nov 29, 2024
@alihamdan alihamdan self-assigned this Nov 29, 2024
@alihamdan alihamdan marked this pull request as ready for review December 1, 2024 11:10
@alihamdan alihamdan merged commit 7c062c0 into develop Dec 1, 2024
6 checks passed
@alihamdan alihamdan deleted the fix-json branch December 1, 2024 11:14
@benoit9126 benoit9126 mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant