Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

[Suggestion] Replace NOT THIS TIME TIMOTHY #18

Open
Vladg24YT opened this issue Jul 21, 2022 · 2 comments
Open

[Suggestion] Replace NOT THIS TIME TIMOTHY #18

Vladg24YT opened this issue Jul 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Vladg24YT
Copy link
Contributor

This happens when

Collections.sort((List)this.worldRenderersToUpdate, (Comparator)new RenderSorter(entityPlayer));

in RenderGlobal.updateRenderers() throws an IllegalArgumentException.

I suggest replacing

catch (IllegalArgumentException ex) {
    System.out.println("NOT THIS TIME TIMOTHY");
}

with

catch (IllegalArgumentException ex) {
    MinecraftServer.logger.log(Level.SEVERE, "Error updating renderers", ex);
}
@5GameMaker 5GameMaker added the enhancement New feature or request label Jul 22, 2022
@Vladg24YT
Copy link
Contributor Author

Vladg24YT commented Aug 2, 2022

JVM argument -Djava.util.Arrays.useLegacyMergeSort=true seems to fix the issue with sorting entirely

@Vladg24YT
Copy link
Contributor Author

The following code at the beginning of the runtime execution should exclude the need for an additional jvm argument

System.setProperty("java.util.Arrays.useLegacyMergeSort", "true");

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants