-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: midnight edition #314
Draft
TorchedSammy
wants to merge
25
commits into
master
Choose a base branch
from
midnight-edition
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
future plans: add the ability to use c lua (or luajit) with hilbish benefits? speed, i guess?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hilbish: Midnight Edition is a build of Hilbish which uses C Lua via a binding library instead of the natively Go written golua library. This means Hilbish might be able to use C Lua libraries and can be compiled with LuaJIT, which speeds up Lua code.
When this is implemented, Midnight Edition will just be a build tag to swap to it. It will have the Midnight Edition moniker everywhere the Hilbish name shows (so the version flag). There will also be an added
hilbish.midnightEdition
boolean to indicate if the build is Midnight Edition for plugins.The standard edition, which is all native Go, will always be more supported than Midnight Edition.
Compiling
Midnight Edition can be compiled by running:
go-task midnight
If you want to switch to LuaJIT, you can set the LUA environment variable, example:
LUA=luajit go-task midnight
It is not recommended to change the version to anything that isn't either Lua 5.4 or
LuaJIT, since Hilbish depends on Lua 5.4 support.
Basics
Rewrite Libraries to use Moonlight
Modules
Functionality
Finishing Touches