Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: midnight edition #314

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

feat: midnight edition #314

wants to merge 25 commits into from

Conversation

TorchedSammy
Copy link
Member

@TorchedSammy TorchedSammy commented Jul 19, 2024

Hilbish: Midnight Edition is a build of Hilbish which uses C Lua via a binding library instead of the natively Go written golua library. This means Hilbish might be able to use C Lua libraries and can be compiled with LuaJIT, which speeds up Lua code.

When this is implemented, Midnight Edition will just be a build tag to swap to it. It will have the Midnight Edition moniker everywhere the Hilbish name shows (so the version flag). There will also be an added hilbish.midnightEdition boolean to indicate if the build is Midnight Edition for plugins.

The standard edition, which is all native Go, will always be more supported than Midnight Edition.

Compiling

Midnight Edition can be compiled by running:
go-task midnight

If you want to switch to LuaJIT, you can set the LUA environment variable, example:
LUA=luajit go-task midnight

It is not recommended to change the version to anything that isn't either Lua 5.4 or
LuaJIT, since Hilbish depends on Lua 5.4 support.

Basics

  • First Milestone: Compiles with Moonlight abstraction library
  • Moonlight: Golua port
    • Compiles
    • Starts
    • Starts (without crashing)
    • Exec without errors
  • Moonlight: C Lua port
    • Compiles
    • Starts
    • Starts (without crashing)
    • Exec without errors

Rewrite Libraries to use Moonlight

  • Bait
  • Commander
  • FS
  • Terminal

Modules

  • Hilbish
    • Functions
    • alias
    • appendPath
    • complete
    • cwd
    • exec
    • runnerMode
    • goro
    • highlighter
    • hinter
    • multiprompt
    • prependPath
    • prompt
    • inputMode
    • interval
    • read
    • run
    • timeout
    • which
  • hilbish.aliases
  • hilbish.completion
  • hilbish.editor
  • hilbish.history
  • hilbish.jobs
  • hilbish.module
  • hilbish.os
  • hilbish.runner
  • hilbish.timers
  • hilbish.userDir

Functionality

  • Aliases
  • Runner Mode
  • Input Mode
  • Hints
  • Highlighter
  • Job Management
  • Vim mode
  • Native Modules
    • Refactor to make them work with Midnight Edition?

Finishing Touches

  • hilbish.midnightEdition
  • "Midnight Edition" moniker

@TorchedSammy TorchedSammy added this to the v2.4 (Celandine) milestone Jul 19, 2024
@TorchedSammy TorchedSammy marked this pull request as draft July 20, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant