Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide input operand for gccrs #3151

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Provide input operand for gccrs #3151

merged 2 commits into from
Oct 17, 2024

Conversation

badumbatish
Copy link
Contributor

fixes #3149

gcc/rust/ChangeLog:

* backend/rust-compile-asm.cc (CompileAsm::asm_construct_inputs): Provide input operand for gccrs
* expand/rust-macro-builtins-asm.cc (parse_reg_operand_in): Move expr to In (expand_inline_asm_strings): Add comments to debug strings

gcc/testsuite/ChangeLog:

* rust/compile/inline_asm_parse_operand.rs: Remove inout, functionality not supported. Remove redundant {}
* rust/execute/torture/inline_asm_mov_x_5_ARM.rs: Add operand in
* rust/execute/torture/inline_asm_mov_x_5_x86_64.rs: Likewise

@badumbatish
Copy link
Contributor Author

failing clang format on missing packages from github action

Traceback (most recent call last):
  File "/run-clang-format.py", line 25, in <module>
    from distutils.util import strtobool
ModuleNotFoundError: No module named 'distutils'

@P-E-P
Copy link
Member

P-E-P commented Sep 5, 2024

You should soon be able to rebase against master once #3152 is merged.

@P-E-P P-E-P added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@P-E-P P-E-P added this pull request to the merge queue Oct 15, 2024
@P-E-P P-E-P removed this pull request from the merge queue due to a manual request Oct 15, 2024
@P-E-P
Copy link
Member

P-E-P commented Oct 16, 2024

@badumbatish There are some build errors would you be able to rebase on master and fix those ? If you're short on time ping me and I'll do it myself.

@badumbatish
Copy link
Contributor Author

hmm it looks clean on my end, maybe i should rebase and see

@badumbatish
Provide input operand for gccrs
e7ff6be 
gcc/rust/ChangeLog:

	* backend/rust-compile-asm.cc (CompileAsm::asm_construct_inputs):
	Provide input operand for gccrs
	* expand/rust-macro-builtins-asm.cc (parse_reg_operand_in):
	Move expr to In
	(expand_inline_asm_strings):
	Add comments to debug strings

gcc/testsuite/ChangeLog:

	* rust/compile/inline_asm_parse_operand.rs:
	Remove inout, functionality not supported. Remove redundant {}
	* rust/execute/torture/inline_asm_mov_x_5_ARM.rs: Add operand in
	* rust/execute/torture/inline_asm_mov_x_5_x86_64.rs: Likewise
@badumbatish
Copy link
Contributor Author

i see Owen has improved the code infra around my part :) i'm very happy

@badumbatish
Fix compiler error on ast wrong implicit construct push_back
12a7957 
gcc/rust/ChangeLog:

	* expand/rust-macro-builtins-asm.cc (parse_reg_operand_in): Fix
	compiler error on ast wrong implicit construct push_back
@badumbatish
Copy link
Contributor Author

things should be fixed now, thanks for pinging me Pierre-Emmanuel :)

@P-E-P P-E-P added this pull request to the merge queue Oct 17, 2024
Merged via the queue into Rust-GCC:master with commit 6708d35 Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up input operand tree for inline asm
2 participants
@badumbatish @P-E-P