CI: pin nightly; test minimal-versions on stable #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pins to nightly-2023-10-01 to prevent regressions - On `minimal-versions`, only uses nightly to resolve versions, and runs tests on stable instead
Merged
newpavlov
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
It looks good as a temporary measure. But I think we should revert it after the regression is fixed. Do we know if someone create a Rust issue for it?
UPD: The issue is rust-lang/rust#117120 and it looks like it was already fixed. We probably can simply wait for a future Nightly release with the fix.
|
I think it would be good to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal-versionsonly uses nightly to resolve versions, and runs tests on stable insteadThis is a workaround for build failures we're seeing due to a recent nightly regression. See:
https://github.com/RustCrypto/RSA/actions/runs/6655788342/job/18086838437?pr=377
https://github.com/RustCrypto/RSA/actions/runs/6655788342/job/18086838800?pr=377