Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marvin toolkit container #400

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

xuganyu96
Copy link
Contributor

This is an attempt to make the Marvin attack analysis more reproducible for RustCrypto/RSA. The Dockerfile and entrypoint script are both rough proofs of concept. It would be great if the maintainers can suggest how we can handle the outputs of the analysis, whether to test rsa1024 and rsa4096, whether this should be part of CI/CD, among other things.

@xuganyu96 xuganyu96 marked this pull request as draft December 11, 2023 16:18
@tarcieri
Copy link
Member

This looks fine to me. Will try it out locally.

@xuganyu96 xuganyu96 marked this pull request as ready for review December 14, 2023 04:13
@xuganyu96
Copy link
Contributor Author

@tarcieri @dignifiedquire

This PR is ready for review. The main feature of this PR is a container that packages the Marvin toolkit. See the added README.md for how to build and run the container. Some notable features include:

  1. CLI allows specifying -s <RSA_bits> -n <repeat>
  2. Custom Cargo.toml for the test harness if custom version of RustCrypto/RSA and/or RustCrypto/crypto-bigint is needed
  3. Preserve the generated keys, ciphertexts, and analysis results by copying them into a location that can be mounted into the host file system

@tarcieri
Copy link
Member

Cool, I'll try to test it out soon

@tarcieri tarcieri merged commit d011ca5 into RustCrypto:master Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants