From 3f542db0113424be4cea246c06dbfb010fb9257c Mon Sep 17 00:00:00 2001 From: Ryan Liang Date: Wed, 11 Oct 2023 00:41:42 -0400 Subject: [PATCH] Add null check for endpoint testing Signed-off-by: Ryan Liang --- .../opensearch/security/http/OnBehalfOfAuthenticatorTest.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java b/src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java index b538c26321..0b81c23554 100644 --- a/src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java +++ b/src/test/java/org/opensearch/security/http/OnBehalfOfAuthenticatorTest.java @@ -489,6 +489,7 @@ public void testRequestNotAllowed() { Mockito.when(mockedRequest1.path()).thenReturn(SECURITY_PREFIX + ON_BEHALF_OF_SUFFIX); Mockito.when(mockedRequest1.method()).thenReturn(POST); Assert.assertFalse(oboAuth.isRequestAllowed(mockedRequest1)); + Assert.assertNull(oboAuth.extractCredentials(mockedRequest1, null)); // Test PUT on password changing endpoint SecurityRequest mockedRequest2 = mock(SecurityRequest.class); @@ -496,6 +497,7 @@ public void testRequestNotAllowed() { Mockito.when(mockedRequest2.path()).thenReturn(SECURITY_PREFIX + ACCOUNT_SUFFIX); Mockito.when(mockedRequest2.method()).thenReturn(PUT); Assert.assertFalse(oboAuth.isRequestAllowed(mockedRequest2)); + Assert.assertNull(oboAuth.extractCredentials(mockedRequest2, null)); } /** extracts a default user credential from a request header */