Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the required properties for Mail Destinations #3

Closed
sebastianesch opened this issue Feb 13, 2024 · 5 comments
Closed

Include the required properties for Mail Destinations #3

sebastianesch opened this issue Feb 13, 2024 · 5 comments
Assignees
Labels
contribution Valuable Contribution in-discussion This item is being discussed internally type/clarity Something was unclear in the documentation. type/content-gaps Something essential is missing in the documentation.

Comments

@sebastianesch
Copy link

sebastianesch commented Feb 13, 2024

Issue description

Step 6 states: "Optional: You can enter additional properties."

Mail Destinations have mandatory "additional" properties that have to be filled. It would be nice to include those here in the documentation.

E.g.:

  • mail.smtp.host
  • mail.smtp.port
  • mail.user
  • mail.password

E.g. when you use the destination via the SAP Cloud SDK - which should link to this page - see SAP/cloud-sdk#1709.

Kind regards,
Sebastian

Feedback Type (Optional)

content gaps

Page Title on SAP Help Portal (prefilled)

Create Mail Destinations

Page URL on SAP Help Portal (prefilled)

https://help.sap.com/docs/connectivity/sap-btp-connectivity-cf/create-mail-destinations?version=Cloud

@Frank1Mueller
Copy link
Contributor

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

@Frank1Mueller Frank1Mueller added the type/content-gaps Something essential is missing in the documentation. label Feb 14, 2024
@Frank1Mueller
Copy link
Contributor

Frank1Mueller commented Feb 14, 2024

Thanks again for your feedback, Sebastian.

This is definitely a good point.

Before updating the documentation, I'd like to discuss some details:

From my perspective, only the first parameter in your list (mail.smtp.host) is a mandatory "additional" parameter. mail.smtp.port might use the smtp standard port if not defined. mail.user and mail.password are actually not "additional" parameters, but standard parameters, and only required if you use authentication type "Basic Authentication".

Do you agree with this definition?

Best regards

Frank

@sebastianesch
Copy link
Author

I agree with the definition, but they go into the "additional" properties of the destination. :)

From my point of view, the documentation currently does not explain which properties are required for different scenarios. I had to step trough the Cloud SDK mail client in the debugger to figure out how to setup the destination.

Kind regards,
Sebastian

@Frank1Mueller
Copy link
Contributor

Frank1Mueller commented Feb 15, 2024

Hi Sebastian,

thanks a lot for your reply.

Yes, you're definitely right. Some properties are listed as "additional", though being present as standard properties in the relevant scenarios. This is a known inconsistency that unfortunately cannot be solved completely by just updating the documentation. However, the dev colleagues are currently working on a new version of the destinations editor that includes an improved "additional properties" section.
For now, regarding the different destination scenarios (in terms of "authentication types used") I will add the parameter mail.smtp.host as mandatory property in documentation, because in fact it is (regardless of the scenario used), and should actually be a standard parameter. Also, I will provide a link to the detailed parameter list for each authentication type.
I hope this will help at least a little bit for the time being.

@Frank1Mueller Frank1Mueller added contribution Valuable Contribution type/clarity Something was unclear in the documentation. labels Feb 16, 2024
Copy link

sap-doc-bot bot commented Feb 16, 2024

Thank you for your valuable feedback contribution, @sebastianesch! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution in-discussion This item is being discussed internally type/clarity Something was unclear in the documentation. type/content-gaps Something essential is missing in the documentation.
Projects
None yet
Development

No branches or pull requests

2 participants