Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide an example of a destination property to add custom SAML attributes #8

Closed
piejanssens opened this issue Jul 18, 2024 · 3 comments
Assignees
Labels
follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally not-doc-issue Reported issue is not a documentation issue. size/s Requires minimal effort to get changed. type/clarity Something was unclear in the documentation. type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@piejanssens
Copy link

Issue description

I want to have a destination of the type OAuth2SAMLBearerAssertion that requires a custom SAML attribute.
This is required to request a learning-only user OAuth access token from the SuccessFactors OAuth token server (see bottom https://help.sap.com/docs/SAP_SUCCESSFACTORS_PLATFORM/2abbb39286994389bb0f1f4418773a7c/4e27e8f6ae2748ab9f23228dd6a31b06.html).

From the documentation it is not clear to me how I can add an "additional property" in the destination.

I tried adding a combination of the properties below, but it's not working as expected and it's not clear that this would be indeed the way to do this.

  • user_attributes.external_user = true
  • skipUserAttributesPrefixInSAMLAttributes = true

Feedback Type (Optional)

clarity

Page Title on SAP Help Portal (prefilled)

SAML Assertion Authentication

Page URL on SAP Help Portal (prefilled)

https://help.sap.com/docs/connectivity/sap-btp-connectivity-cf/saml-assertion-authentication

@Frank1Mueller
Copy link
Contributor

Dear Pieter,

thanks a lot for reaching out. We'll analyze the issue and get back to you soon.

Best regards

Frank

@Frank1Mueller Frank1Mueller added follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally size/s Requires minimal effort to get changed. type/clarity Something was unclear in the documentation. type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Jul 18, 2024
@Frank1Mueller
Copy link
Contributor

Hi Peter,

we have now had a look at your issue.

Basically, adding the additional parameter to the destination seems to be correct as you described it.

However, the additional parameter only works if the attribute is part of the data in the XSUAA (aka SAP UAA) service. If so, it will already be in the assertion as long as the user token has the additional user_attributes scope. If it is not known to XSUAA, it cannot be part of the assertion.

For more information see also:

https://help.sap.com/docs/connectivity/sap-btp-connectivity-cf/consuming-destination-service?q=xsuaa
https://help.sap.com/docs/connectivity/sap-btp-connectivity-cf/user-propagation-via-saml-2-0-bearer-assertion-flow?q=user_attributes%20scope

Best regards
Frank

@piejanssens
Copy link
Author

Hi Frank,

I appreciate the clarification. In our use case, we are using the "systemUser" attribute so no UAA data coming in.
I'll do some tests using a JWT containing the user_attributes instead.

Best regards,

Pieter

@Frank1Mueller Frank1Mueller self-assigned this Jul 30, 2024
@Frank1Mueller Frank1Mueller added the not-doc-issue Reported issue is not a documentation issue. label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up-with/dev Clarification with development needed. in-discussion This item is being discussed internally not-doc-issue Reported issue is not a documentation issue. size/s Requires minimal effort to get changed. type/clarity Something was unclear in the documentation. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

No branches or pull requests

2 participants